New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Code type cells in horizontalScrollbar #24576
base: main
Are you sure you want to change the base?
Ignore Code type cells in horizontalScrollbar #24576
Conversation
@@ -355,7 +355,7 @@ export class CodeComponent extends CellView implements OnInit, OnChanges { | |||
horizontalScrollbar.style.top = horizontalTop + 'px'; | |||
horizontalScrollbar.style.bottom = ''; | |||
} | |||
} else { | |||
} else if (this.cellModel.cellType !== CellTypes.Code) { | |||
// If horizontal scrollbar is not needed then set do not show it | |||
horizontalScrollbar.style.opacity = '0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we even using opacity to hide the scrollbar? I would think display: none
would be the better option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we aren't regressing the scenarios this was originally added for too : #17083
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to keep in mind is the word wrap setting in all of these code paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that display:none
could be used here so that the dom layout would will not need to compute the layout for the horizontal scrollbar. I believe when I was testing all the paths it was much easier to have this change so that I was able to still see the scrollbar in the DOM in order to change it if necessary.
@unlock21 please change to using display instead :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VasuBhog changed it to use display.
You all got to this way faster than I'd expected, thank you!
@corivera would you mind taking a look at this branch and validating that changes here look good? |
Sure |
#21145
Ignore Code Cells being applied with Markdown Cell specific behavior around the horizontal scrollbar.
The scrollbar is already there, just opacity was set to 0.
Before:
After: