Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #2145, #2190 and #2196 to master #2192

Merged
merged 3 commits into from May 7, 2020
Merged

Cherry-pick #2145, #2190 and #2196 to master #2192

merged 3 commits into from May 7, 2020

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented May 6, 2020 •
edited

Fixes #2197
Fixes #2191
Fixes #2185

Specific Changes

garypretty and others added 2 commits May 6, 2020 13:22
@garypretty @stevengum
Add Dialog / PageView telemetry (#2145)
b64b61d 
* Update app insights package version

* Add PageView logging

* move TelemetryView helper to botTelemetryClient.ts

* remove telemetry Extensions class, harden helper method, add tests

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
@stevengum
move botbuilder-lg and adaptive-expressions out of preview (#2190)
a60cd3a 
* move botbuilder-lg and adaptive-expressions out of preview

* correct set-version script in preview packages

* restore preview packages to using Version instead of PreviewPackageVersion
@stevengum stevengum requested a review from benbrown as a code owner May 6, 2020 20:28
@coveralls
Copy link

coveralls commented May 6, 2020 •
edited

Pull Request Test Coverage Report for Build 128921

  • 31 of 32 (96.88%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 79.942%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 128753: 0.1%
Covered Lines: 12577
Relevant Lines: 15011
💛 - Coveralls

@stevengum stevengum changed the title Cherry-pick #2145 and #2190 to master Cherry-pick #2145, #2190 and #2196 to master May 6, 2020
@stevengum
Copy link
Member Author

Working on fixing the SkillDialog tests right now against 4.9

@cleemullins cleemullins merged commit 77c49e3 into master May 7, 2020
@cleemullins cleemullins deleted the stgum/4.9/cherrypicks branch May 7, 2020 01:15
@stevengum stevengum mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@cleemullins cleemullins cleemullins approved these changes

@BruceHaley BruceHaley Awaiting requested review from BruceHaley

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cherrypick PR #2196 into master Cherrypick PR #2190 into master Cherrypick PR #2145 into master
5 participants
@stevengum @coveralls @Stevenic @cleemullins @garypretty