Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add accept header #3983

Merged
merged 7 commits into from
Nov 18, 2021
Merged

fix: add accept header #3983

merged 7 commits into from
Nov 18, 2021

Conversation

EricDahlvang
Copy link
Member

Fixes #3962

@EricDahlvang EricDahlvang requested a review from a team as a code owner November 17, 2021 22:17
@EricDahlvang EricDahlvang changed the title Eric/add accept header add accept header Nov 17, 2021
@EricDahlvang EricDahlvang changed the title add accept header fix: add accept header Nov 17, 2021
@joshgummersall
Copy link
Contributor

I think we probably need this code here as well: https://github.com/microsoft/botbuilder-js/blob/main/libraries/botframework-connector/src/auth/connectorFactoryImpl.ts

@coveralls
Copy link

coveralls commented Nov 17, 2021 •
edited

Pull Request Test Coverage Report for Build 1474092770

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 84.54%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-connector/src/auth/connectorFactoryImpl.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 1467354164: -0.002%
Covered Lines: 19660
Relevant Lines: 22028
💛 - Coveralls

@EricDahlvang EricDahlvang merged commit 2bd9b49 into main Nov 18, 2021
@EricDahlvang EricDahlvang deleted the eric/addAcceptHeader branch November 18, 2021 00:07
EricDahlvang added a commit that referenced this pull request Nov 18, 2021
@EricDahlvang
fix: add accept header (#3983)
98a2b96 
* Add accept header to connectorclient outgoing calls

* fix accept header test

* Simplify accept header test

* update accept header failure message

* Add accept header to connectorFactoryImpl connector client options

* fix spacing

* lint
joshgummersall pushed a commit that referenced this pull request Nov 18, 2021
@EricDahlvang
fix: add accept header (#3983) (#3984)
7b0ff53 
* Add accept header to connectorclient outgoing calls

* fix accept header test

* Simplify accept header test

* update accept header failure message

* Add accept header to connectorFactoryImpl connector client options

* fix spacing

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Add */* accept header to ConnectorClient httpclient (#5926)
3 participants
@EricDahlvang @joshgummersall @coveralls