Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [#3997] Move Javascript generators from Samples to "generators" - Core Bot #4013

Merged
merged 2 commits into from
Jan 20, 2022
Merged

feat: [#3997] Move Javascript generators from Samples to "generators" - Core Bot #4013

merged 2 commits into from
Jan 20, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #3997
#minor

Description

This PR adds the generator-botbuilder's Core bot from the BotBuider-Samples repository.

Detailed Changes

  • Added Core bot templates for JS and TS versions.

Testing

These images show the generator-botbuilder working for the Core bot.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 13, 2021 18:24
@coveralls
Copy link

coveralls commented Dec 13, 2021 •
edited

Pull Request Test Coverage Report for Build 1721087714

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.545%
Totals Coverage Status
Change from base Build 1700082174: -0.003%
Covered Lines: 19667
Relevant Lines: 22035
💛 - Coveralls

BruceHaley
BruceHaley approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@BruceHaley BruceHaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mrivera-ms mrivera-ms merged commit 752bdd5 into main Jan 20, 2022
@mrivera-ms mrivera-ms deleted the southworks/add/generators-botbuilder-core branch January 20, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceHaley BruceHaley BruceHaley approved these changes

@mrivera-ms mrivera-ms mrivera-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ceciliaavila @coveralls @BruceHaley @mrivera-ms