Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underscore Component Governance vulnerability #4076

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

BruceHaley
Copy link
Contributor

Fixes #minor

Description

Fixes the high severity follow-redirects vulnerability listed in this CG alert:
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/5916786?typeId=10422422

Vulnerability: underscore 1.8.3. Recommended to upgrade to v 1.12.1.

Force dependency underscore to version 1.13.1

Specific Changes

Add a resolutions section to the root package.json.

@BruceHaley BruceHaley requested a review from a team as a code owner January 24, 2022 23:23
@BruceHaley BruceHaley added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label Jan 24, 2022
@coveralls
Copy link

coveralls commented Jan 24, 2022

Pull Request Test Coverage Report for Build 1775807312

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.546%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 1775778494: -0.003%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@mrivera-ms
Copy link
Contributor

@BruceHaley, could you please fix the conflict in package.json so we can merge? Thank you.

@BruceHaley BruceHaley merged commit 9a39cf6 into main Feb 1, 2022
@BruceHaley BruceHaley deleted the bruce/cgalertfix1-24 branch February 1, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants