Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CG alerts for follow-redirects 1.5.10, axios 0.19.2 #4093

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Feb 3, 2022

Fixes #minor

Description

High severity vulnerability.
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/4059014?typeId=10406766
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/6373557?typeId=10406766

Found in this JS daily build

Upgrade @azure/cognitiveservices-luis-runtime@2.0.0 to latest version 5.0.0.
Upgrade axios@0.21.4 to latest version 0.25.0.

@BruceHaley BruceHaley requested a review from a team as a code owner February 3, 2022 01:35
@BruceHaley BruceHaley changed the title Fix CG alerts for follow-redirects 1.5.10, axios 0.19.2 fix: CG alerts for follow-redirects 1.5.10, axios 0.19.2 Feb 3, 2022
@coveralls
Copy link

coveralls commented Feb 8, 2022

Pull Request Test Coverage Report for Build 1809484058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 132 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.003%) to 84.546%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/jsonExtensions.ts 1 93.33%
libraries/botbuilder-dialogs-adaptive/src/telemetryExtensions.ts 1 40.0%
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder-dialogs-adaptive/src/conditions/onIntent.ts 2 87.5%
libraries/botbuilder-dialogs-adaptive/src/languagePolicy.ts 2 84.62%
libraries/botbuilder-dialogs-adaptive/src/entityAssignment.ts 3 79.63%
libraries/botbuilder-dialogs-adaptive/src/actionContext.ts 4 82.98%
libraries/botbuilder-dialogs-adaptive/src/entityInfo.ts 6 40.91%
libraries/botbuilder-dialogs-adaptive/src/conditions/onCondition.ts 7 87.5%
libraries/botbuilder-dialogs-adaptive/src/entityAssignmentComparer.ts 10 12.5%
Totals Coverage Status
Change from base Build 1786622000: -0.003%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 416fd55 into main Feb 8, 2022
@mrivera-ms mrivera-ms deleted the bruce/cgfix2-2 branch February 8, 2022 00:45
BruceHaley pushed a commit that referenced this pull request Feb 8, 2022
mrivera-ms pushed a commit that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants