port: [#3943] Add ShowSignInLink to OAuthPromptSettings (#5906) #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1970573738
💛 - Coveralls |
mrivera-ms
approved these changes
Mar 11, 2022
mrivera-ms
deleted the
southworks/port/add-show-sign-in-link-to-oauth-prompet-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3943
Description
This PR ports the changes in BotBuilder-DotNet's PR#5906 to add the showSignInLink property in OAuthPromp allowing the user to decide if a sign-in link should be shown or not.
Specific Changes
oauthPrompt.tsto include the showSignInLink property and the validation to set the sign-in link.oauthPrompt.test.jsto cover the different test cases.botbuilder-dialogs.api.mdto include the new property.Testing
This image shows the new unit tests passing.
