Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DockerFile security analysis warning - JS #4265

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

BruceHaley
Copy link
Contributor

Fixes #minor

Description

The warning:
##[warning]Container security analysis found 1 violations. This repo has one or more docker files having references to images from external registries.

Example: E2E_BF-Streaming-DL-ASE_Test

Specific Changes

Change the FROM in .gitpod.Dockerfile to reference the appropriate container image in the Microsoft Artifact Registry.

@BruceHaley BruceHaley requested a review from gabog June 15, 2022 22:43
@BruceHaley BruceHaley marked this pull request as ready for review June 15, 2022 22:44
@BruceHaley BruceHaley requested a review from a team as a code owner June 15, 2022 22:44
@BruceHaley BruceHaley changed the title fix: DockerFile security analysis warning fix: DockerFile security analysis warning - JS Jun 15, 2022
@coveralls
Copy link

coveralls commented Jun 16, 2022

Pull Request Test Coverage Report for Build 2505564343

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.07%) to 84.482%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 2505148109: 1.07%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@BruceHaley BruceHaley merged commit 0344d97 into main Jun 16, 2022
@BruceHaley BruceHaley deleted the bruce/dockerfix6-15 branch June 16, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants