Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get chrome version task in browser test pipeline #4329

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Sep 21, 2022

Fixes #minor

Description

In pipeline JS-Functional-Tests-BrowserBot-yaml, task 'Get second latest chromedriver version number from npmjs.com' is not getting the correct version. This fixes that.

@BruceHaley BruceHaley changed the title Fix get chrome version task in browser test pipeline fix: get chrome version task in browser test pipeline Sep 21, 2022
@BruceHaley BruceHaley marked this pull request as ready for review September 21, 2022 01:08
@BruceHaley BruceHaley requested a review from a team as a code owner September 21, 2022 01:08
@coveralls
Copy link

coveralls commented Sep 21, 2022

Pull Request Test Coverage Report for Build 3094504826

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.611%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3093675260: -0.003%
Covered Lines: 19923
Relevant Lines: 22308

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a79ddf9 into main Sep 21, 2022
@tracyboehrer tracyboehrer deleted the bruce/fixgetchromeversion9-20 branch September 21, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants