Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4440][Bot node.js] Compile error for accessing "conversation" and "organizer" fields for get meeting details bot API #4442

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4440

Description

This PR fixes the compile error in TS when trying to access the properties returned by the getMeetingInfo function.
It replaces the TeamsMeetingInfo return type with the correct MeetingInfo type, also matching with the .NET implementation.

Note: Although this would be a breaking change, as the method's signature was updated, the data returned by the method remained the same. Anyone using the old interface wouldn't be able to access its properties.

Specific Changes

  • Replaced TeamsMeetingInfo with MeetingInfo as return type in getMeetingInfo function.
  • Updated TeamsMeetingInfoResponse type to use the correct MeetingInfo interface.
  • Updated method's signature in botbuilder.api.md.

Testing

These images show the compile error solved and the meeting info properly returned by the method.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 15, 2023 20:11
@coveralls
Copy link

coveralls commented Mar 15, 2023

Pull Request Test Coverage Report for Build 8333618617

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.48%

Totals Coverage Status
Change from base Build 8147499486: 0.0%
Covered Lines: 20414
Relevant Lines: 22880

💛 - Coveralls

@tracyboehrer
Copy link
Member

@ceciliaavila This does change the signatures so the test-compat fails

@ceciliaavila
Copy link
Collaborator Author

@ceciliaavila This does change the signatures so the test-compat fails

Yes, I'm fixing the check now.

Note: Although this would be a breaking change, as the method's signature was updated, the data returned by the method remained the same. Anyone using the old interface wouldn't be able to access its properties.

@tracyboehrer tracyboehrer merged commit f487de2 into main Mar 19, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/teams-meeting-info branch March 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants