Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Update @azure/msal-node and @azure/msal-browser #4619

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Feb 14, 2024

Fixes #4599

Description

This PR updates the versions of the packages @azure/msal-node and @azure/msal-browser to avoid the use of deprecated versions.

Specific Changes

  • Updated @azure/msal-node to ^1.18.4 in botbuilder, botframework-connector and tools.
  • Added resolutions axios: 0.21.4, @azure/msal-node: ^1.18.4 and @azure/msal-browser: ^2.38.3.

Testing

The following image shows an echo bot working with authentication after the updates.
image

@JhontSouth JhontSouth requested a review from a team as a code owner February 14, 2024 14:03
@coveralls
Copy link

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 7916530491

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.48%

Totals Coverage Status
Change from base Build 7887967277: 0.0%
Covered Lines: 20414
Relevant Lines: 22880

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 70108af into main Feb 15, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/msal-node-and-browser branch February 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@azure/msal-node and @azure/msal-browser versions are deprecated (both have new major versions)
3 participants