-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Implement Error Handling with Try-Catch for processActivity in a Promise-returning Context #4656
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8925522130Details
💛 - Coveralls |
…AdaptiveDialogTests/AdaptiveDialog_BindingOptionsAcrossAdaptiveDialogs/AdaptiveDialog_BindingOptionsAcrossAdaptiveDialogs.AgeDialog.dialogI've removed the unwanted-file.js from this pull request as it was included accidentally. I've removed the file from this pull request as it was included accidentally.
@Amrit10737726 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Hi @tracyboehrer, Since the issue microsoft/BotBuilder-Samples#2014 is an old one (from 2019, pre CloudAdapter existence), we were able to reproduce it by using BotFrameworkAdapter (v4.6.2). |
#minor
microsoft/BotBuilder-Samples#2014
Should we consider: microsoft/BotBuilder-Samples#3148