Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deterministic GUID generation #176

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

kaibocai
Copy link
Member

This is the work needed to allow orchestrations to generate random GUIDs in a deterministic way. It borrows from the similar logic in the durabletask-dotnet SDK.

Also this is request from dapr/java-sdk#931

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question about a doc comment, but otherwise I think this implementation looks good.

@kaibocai kaibocai merged commit 333511b into main Oct 25, 2023
3 checks passed
@kaibocai kaibocai deleted the kaibocai/determinstic-uuid branch October 25, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants