Phase 1 of removing the rundown protection for invoke #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
mikeagun
previously approved these changes
May 11, 2024
shankarseal
reviewed
May 11, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
mikeagun
reviewed
May 14, 2024
dthaler
reviewed
May 14, 2024
dthaler
previously approved these changes
May 14, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
mikeagun
previously approved these changes
May 15, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
added 2 commits
May 15, 2024 11:05
…ent deadlocks Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
|
Fixed deadlock during fault injection. |
mtfriesen
reviewed
May 15, 2024
|
Fault injection still failing. |
shankarseal
reviewed
May 15, 2024
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
mtfriesen
approved these changes
May 15, 2024
|
Fixed leak of ebpf_program_t during failure path. |
shankarseal
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Jun 3, 2024
* Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Fix SAL annotation error Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Fix SAL annotation error Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Ensure that _ebpf_program_free always run outside of an epoch to prevent deadlocks Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Revert unrelated change Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback and leak fix Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3483
Description
This change eliminates the need to acquire/release the rundown protection on the program information provider. Instead the pointer to the program information is used as a flag to signal when the provider is detaching and the provider blocks waiting for the current epoch to end.
This ensures that if a thread in the invoke path sees the program information as present (i.e. the flag is set) then it can safely assume the program information will remain valid until epoch_exit is called.
Future changes:
Assuming this works correctly, there might be a breaking change to remove the client context from begin/end invoke.
Testing
CI/CD
Documentation
No.
Installation
No.