Cache choco packages to work around connectivity issues #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
added 3 commits
May 10, 2024 15:56
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
dthaler
reviewed
May 11, 2024
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
approved these changes
May 13, 2024
dv-msft
approved these changes
May 21, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Jun 3, 2024
* Cache choco packages to work around connectivity issues Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Download file as cache key if needed Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Apply suggestions from code review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
shankarseal
added a commit
that referenced
this pull request
Jun 5, 2024
* Phase 1 of removing the rundown protection for invoke (#3534) * Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Fix SAL annotation error Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Phase 1 of removing the rundown protection for invoke Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Fix SAL annotation error Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Ensure that _ebpf_program_free always run outside of an epoch to prevent deadlocks Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Revert unrelated change Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * PR feedback and leak fix Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> * Cache choco packages to work around connectivity issues (#3536) * Cache choco packages to work around connectivity issues Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Download file as cache key if needed Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Apply suggestions from code review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Dave Thaler <dthaler1968@gmail.com> * Add option to control the level of verbosity emitted by verifier. (#3570) * Add option to control the level of verbosity emitted by verifier. Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Re-order enums to make normal < informational < verbose Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Apply suggestions from code review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> * PR feedback Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Workaround for verifier failure #643 Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Revert change in ebpf-service verification path Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Dave Thaler <dthaler1968@gmail.com> * Add `total_size` to extension header. (#3573) * change ebpf_extension_header_t to ebpf_version_header_t * revert to ebpf_version_header_t * revert to ebpf_version_header_t * update header * update doc * update doc * use total_size to get the actual struct size * Apply suggestions from code review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> --------- Co-authored-by: Dave Thaler <dthaler1968@gmail.com> * disable tailcall test for now (#3558) Co-authored-by: Dhiren Vispute <Dhiren.Vispute@microsoft.com> * Cleanup batch APIs and remove unused parameter (#3580) Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Sharmi <shpalan@microsoft.com> * Add support for multiple programs per section (#3557) * Allow multiple programs per section Temporarily use a fork of ebpf-verifier until vbpf/ebpf-verifier#642 is merged. Per https://stackoverflow.com/questions/13147170/attribute-always-inline-failing the __attribute__((always_inline)) doesn't do anything unless you also have the "inline" keyword. Signed-off-by: Dave Thaler <dthaler1968@gmail.com> * Update verifier to latest Signed-off-by: Dave Thaler <dthaler1968@gmail.com> * Address comment from Alan Signed-off-by: Dave Thaler <dthaler1968@gmail.com> * Address API compat comment from Anurag Signed-off-by: Dave Thaler <dthaler1968@gmail.com> --------- Signed-off-by: Dave Thaler <dthaler1968@gmail.com> * Add workaround for NmrRegisterClient calling detach (#3594) Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> * move enum to header (#3593) --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Signed-off-by: Dave Thaler <dthaler1968@gmail.com> Co-authored-by: Alan Jowett <alanjo@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Dave Thaler <dthaler1968@gmail.com> Co-authored-by: Anurag Saxena <43585259+saxena-anurag@users.noreply.github.com> Co-authored-by: Dhiren Vispute <86131363+dv-msft@users.noreply.github.com> Co-authored-by: Dhiren Vispute <Dhiren.Vispute@microsoft.com> Co-authored-by: Sharmi <shpalan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
.github/workflows/reusable-test.ymlfile, specifically in thejobs:section. The changes involve setting up a local cache for Chocolatey (choco) packages and adding a cache entry for any installed choco packages. The cache key is based on the hash of the workflow file, so any changes to the choco packages in the file will invalidate the cache.Key changes:
.github/workflows/reusable-test.yml: Added a new step to create a local folder for caching Chocolatey packages. The cache location is set using thechoco config setcommand. This step is skipped if theshould_skipoutput of theskip_checkstep is 'true'..github/workflows/reusable-test.yml: Added another step to cache the Chocolatey packages. The cache uses theactions/cacheaction with a specific commit hash. The cache key is generated using thehashFilesfunction with the workflow file as input. This step is also skipped if theshould_skipoutput of theskip_checkstep is 'true'.Testing
CI/CD
Documentation
No.
Installation
No.