Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: affix typescript to v3.3.3 #1630

Merged
merged 1 commit into from Apr 8, 2019

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Apr 8, 2019

Description

Affixes typescript to v3.3.3 because later versions exhaust allotted memory. Seems to be the same issue as microsoft/TypeScript#30794

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@codeclimate
Copy link

codeclimate bot commented Apr 8, 2019

Code Climate has analyzed commit 3e0034b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.1% (0.0% change).

View more on Code Climate.

@nicholasrice nicholasrice merged commit d557693 into master Apr 8, 2019
@nicholasrice nicholasrice deleted the users/nirice/affix-typescript-version branch April 8, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants