fix: remove link handler in disconnect #6901
Merged
+8
β1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
Click event handler should be removed properly in
disconnect
method ofDefaultLinkHandler
.Since the event listener is added with
useCapture = true
inconnect
method, it's required to setuseCapture = true
inremoveEventListener
according to https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#matching_event_listeners_for_removalπ« Issues
When the
:config
property offast-router
is updated, thetryConnect
method willdisconnect
link handler andconnect
again. In this case, the previousclick
event handler is not properly removed, which results in resource leak.π©βπ» Reviewer Notes
π Test Plan
β Checklist
General
$ yarn change
Component-specific
β Next Steps