Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tslib to the nohoist list #6903

Closed
wants to merge 6 commits into from
Closed

Conversation

radium-v
Copy link
Collaborator

@radium-v radium-v commented Feb 2, 2024

Pull Request

πŸ“– Description

This PR adds tslib to the nohoist list in the root-level package.json. Additionally, it adds tslib as a dependency to both fast-router and fast-react-wrapper (it was previously only a transient dependency).

🎫 Issues

Due to this problem in tslib, tslib is locked to version 2.5.0 in fast-ssr.

πŸ‘©β€πŸ’» Reviewer Notes

For both fast-router and fast-react-wrapper, I marked tslib as a dependency since "importHelpers": true is set in their tsconfigs.

I wasn't sure if all packages should be locked to 2.5.0, since fast-ssr is the only one that uses a class private field.

πŸ“‘ Test Plan

All packages should build and pass all tests as expected.

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Once we upgrade to TypeScript 5+, we should be able to continue using more recent versions of tslib.

@radium-v radium-v changed the title chore: add tslib to the nohoist list Add tslib to the nohoist list Feb 2, 2024
@radium-v radium-v self-assigned this Feb 13, 2024
@janechu
Copy link
Collaborator

janechu commented May 22, 2024

Closing this issue as we are doing alignment work that will switch yarn to npm which will remove the issues with nohoist.

@janechu janechu closed this May 22, 2024
@janechu janechu added the closed:obsolete No longer valid label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants