Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port data grid nav fix to fast-element-1 #6905

Draft
wants to merge 3 commits into
base: archives/fast-element-1
Choose a base branch
from

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Feb 3, 2024

πŸ“– Description

Keyboard events emitted from a data grid cell when a cell's internal navigation is active can incorrectly move focus in the parent grid. Rather than rely on authors to intercept these events the cell component can prevent their propagation.

Additionally, this change adds

a simple 'defaultCellFocusTargetCallback` function that authors can use to move focus to the first element of a cell.
an example of a grid with cells with internal focus targets and internal nav queue
fixes code that detects the current active element to work within shadow doms

This is a port of this pr:
https://github.com/microsoft/fast/pull/6754/files

🎫 Issues

Requested back port of a bug fix.

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • [ x] I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • [] I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant