-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Storybook 8 in FAST Foundation #6929
Conversation
I checked to see if anything we generate is affected by the removal of I'm still investigating if consumers of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for doing this! I'm surprised there weren't more changes needed in the Stories or helper functions.
9de2a4c
to
a1806d9
Compare
β¦eview - use globalThis for html function in tests
- Update csf - Fix storybook helper types - update docs
a1806d9
to
3411cac
Compare
3411cac
to
b9eb5f4
Compare
Pull Request
π Description
This PR updates the FAST Foundation project to use Storybook 8.
@storybook/html-vite
)import type ... from ...
Removesside effect config is no longer affected"sideEffects": false
from thepackage.json
π« Issues
#6698
π©βπ» Reviewer Notes
Most of the changes in this PR can be categorized into a few manageable piles:
#root
to#storybook-root
, and sometimes Playwright thinks it's okay to continue even though the page hasn't finished defining the components.π Test Plan
All tests in
fast-foundation
should pass as expected, though some individual test modules might be flaky in different environments.β Checklist
General
$ yarn change
β Next Steps
#6855