Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
The current
React.createElement
function takes as an parameter the objectnewReactProps
to pass props to the created React component. But we have noticed that some props are not being passed to our React components. When I tested this, I noticed these attributes were not getting passed tonewElementProps
object but not thenewReactProps
.This fix changes the second parameter passed in
React.createElement
to an object that includes both objects, spread.After making this fix, all attributes passed from our web components to their React counterparts.
This is my first attempt at contributing and I realize this change may have performance or other implications. I'm not sure this is the correct fix, but it does solve this issue for us. I'd be happy to test performance or anything else with a bit of guidance from your team.
π« Issues
#6826
π©βπ» Reviewer Notes
Please let me know if there's anything more you need from me or if there's something you think I'm missing.
π Test Plan
I ran Lerna tests (and noted this below in the checkbox for tests)
I'd like to test the performance implicaitons of this, but I'm not sure how to do that
β Checklist
General
$ yarn change