chore(docs): make HMR working properly #1370
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
=======================================
Coverage 73.47% 73.47%
=======================================
Files 778 778
Lines 5859 5859
Branches 1726 1726
=======================================
Hits 4305 4305
Misses 1548 1548
Partials 6 6Continue to review full report at Codecov.
|
layershifter
force-pushed
the
chore/enable-hmr
branch
from
38bf553
to
cba38b0
Compare
| <div style={{ paddingBottom: '10px' }} /> | ||
| {({ element, error, markup }) => ( | ||
| <> | ||
| <Provider.Consumer |
There was a problem hiding this comment.
We don't need Provider.Consumer more there
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
This stuff will be done by react-hot-loader
| import PopupsPrototype from './prototypes/popups' | ||
| import IconViewerPrototype from './prototypes/IconViewer' | ||
| import MenuButtonPrototype from './prototypes/MenuButton' | ||
| import AlertsPrototype from './prototypes/alerts' |
There was a problem hiding this comment.
We're using Webpack 4, these imports will be tree-shaken in production
This change is required: to prevent errors related to HMR like this:
| // https://github.com/webpack/webpack/issues/834#issuecomment-76590576 | ||
| module.hot.accept(exampleSourcesContext.id, () => { | ||
| exampleSourcesContext = require.context('docs/src/exampleSources/', true, /.source.json$/) | ||
| }) |
There was a problem hiding this comment.
Context should be updated separately.
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
@Bugaa92 at least it doesn't make anything worst 😸 It will affect only local development... I will merge it and will be able to detect and fix more cases, so I am opened for feedback when more people will be able to perform live test |
Related #508.
This PR updates:
react-hot-loaderto use their modenhot()APIreact-source-render, I rewrote it to omit React Context (use only render props) and be compatible with HMR (unstable_hotprop)Works properly
Still broken
ProviderOccurred because there is an issue with lost context: gaearon/react-hot-loader#1207