Feat/date picker prototype #13855
Merged
Feat/date picker prototype #13855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymeskar
commented
Jun 30, 2020
packages/fluentui/react-northstar/src/components/Datepicker/DatepickerCalendar.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5dcd3c5:
|
rymeskar
commented
Jun 30, 2020
packages/date-time-utilities/src/dateFormatting/dateFormatting.types.ts
Outdated
Show resolved
Hide resolved
rymeskar
commented
Jun 30, 2020
packages/fluentui/react-northstar/src/components/Datepicker/Datepicker.tsx
Outdated
Show resolved
Hide resolved
rymeskar
commented
Jun 30, 2020
packages/fluentui/react-northstar/src/components/Datepicker/DatepickerCalendar.tsx
Outdated
Show resolved
Hide resolved
pompomon
reviewed
Jul 2, 2020
pompomon
reviewed
Jul 2, 2020
packages/fluentui/react-northstar/src/components/Datepicker/DatepickerCalendar.tsx
Outdated
Show resolved
Hide resolved
rymeskar
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason and
miroslavstastny
as code owners
mnajdova
reviewed
Jul 10, 2020
mnajdova
reviewed
Jul 10, 2020
packages/fluentui/react-northstar/test/specs/components/Datepicker/Datepicker-test.tsx
Outdated
Show resolved
Hide resolved
pompomon
reviewed
Jul 13, 2020
packages/fluentui/react-northstar/src/components/Datepicker/Unstable_Datepicker.tsx
Outdated
Show resolved
Hide resolved
pompomon
approved these changes
Jul 13, 2020
packages/fluentui/react-northstar/test/specs/components/Datepicker/DatepickerCalendar-test.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/react-northstar/src/components/Datepicker/Unstable_Datepicker.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/react-northstar/src/components/Datepicker/DatepickerCalendar.tsx
Outdated
Show resolved
Hide resolved
layershifter
added
the
Fluent UI react-northstar (v0)
…kar/fluentui into feat/date_picker_prototype
|
Hello @pompomon! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This is the initial prototype for Datepicker. The code only includes a basic date picker that has an input, dropdown panel and shows calendar when opened.
The code also defines all the designed props.
Focus areas to test
(optional)