Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default exports [P3] #13916

Merged
merged 1 commit into from Jul 3, 2020
Merged

Conversation

layershifter
Copy link
Member

Description of changes

This PR is a third round of default exports removal, see #12953 (comment).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c819a6c:

Sandbox Source
Fluent UI Button Configuration
keen-wright-h31c7 Configuration

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against c819a6c

@size-auditor
Copy link

size-auditor bot commented Jul 3, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 523f1ed72368da18cb33a6d620a730bd271e8905 (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 877 804 5000
ButtonNext mount 568 551 5000
Checkbox mount 1466 1452 5000
CheckboxBase mount 1230 1198 5000
CheckboxNext mount 1473 1484 5000
ChoiceGroup mount 4699 4616 5000
ComboBox mount 883 891 1000
CommandBar mount 7274 7387 1000
ContextualMenu mount 13237 13242 1000
DefaultButton mount 1011 1039 5000
DetailsRow mount 3303 3453 5000
DetailsRowFast mount 3581 3479 5000
DetailsRowNoStyles mount 3342 3291 5000
Dialog mount 1462 1495 1000
DocumentCardTitle mount 1762 1745 1000
Dropdown mount 2467 2457 5000
FocusZone mount 1730 1727 5000
IconButton mount 1808 1678 5000
Label mount 336 347 5000
Link mount 439 451 5000
LinkNext mount 424 472 5000
MenuButton mount 1426 1401 5000
Nav mount 3215 3154 1000
Panel mount 1408 1404 1000
Persona mount 810 793 1000
Pivot mount 1374 1363 1000
PivotNext mount 1435 1297 1000
PrimaryButton mount 1235 1211 5000
SearchBox mount 1204 1229 5000
SearchBoxNext mount 1248 1247 5000
Slider mount 1466 1463 5000
SliderNext mount 1844 1829 5000
Spinner mount 420 412 5000
SplitButton mount 3068 3078 5000
Stack mount 518 490 5000
StackWithIntrinsicChildren mount 1906 1880 5000
StackWithTextChildren mount 4836 4853 5000
TagPicker mount 2654 2586 5000
Text mount 413 394 5000
TextField mount 1313 1335 5000
ThemeProvider mount 2829 2899 5000
ThemeProvider virtual-rerender 517 516 5000
Toggle mount 814 818 5000
ToggleNext mount 765 787 5000
button mount 123 107 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
HeaderMinimalPerf.default 301 346 0.87:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.46 0.91:1 2000 845
🦄 Button.Fluent 0.1 0.17 0.59:1 5000 510
🔧 Checkbox.Fluent 0.61 0.3 2.03:1 1000 610
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 733
🔧 Dropdown.Fluent 3.16 0.43 7.35:1 1000 3160
🔧 Icon.Fluent 0.12 0.05 2.4:1 5000 624
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 343
🔧 Slider.Fluent 1.5 0.31 4.84:1 1000 1499
🔧 Text.Fluent 0.06 0.02 3:1 5000 307
🦄 Tooltip.Fluent 0.09 17.01 0.01:1 5000 465

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 129 120 1.08:1
HierarchicalTreeMinimalPerf.default 445 413 1.08:1
TextMinimalPerf.default 335 310 1.08:1
GridMinimalPerf.default 336 315 1.07:1
TooltipMinimalPerf.default 781 730 1.07:1
Image.Fluent 343 322 1.07:1
PopupMinimalPerf.default 669 634 1.06:1
PortalMinimalPerf.default 126 119 1.06:1
Button.Fluent 510 481 1.06:1
ChatDuplicateMessagesPerf.default 440 418 1.05:1
DividerMinimalPerf.default 348 332 1.05:1
InputMinimalPerf.default 1097 1043 1.05:1
AnimationMinimalPerf.default 367 352 1.04:1
CardMinimalPerf.default 553 532 1.04:1
ItemLayoutMinimalPerf.default 1249 1197 1.04:1
SegmentMinimalPerf.default 338 326 1.04:1
TableManyItemsPerf.default 2230 2149 1.04:1
TreeMinimalPerf.default 870 836 1.04:1
Avatar.Fluent 845 810 1.04:1
FormMinimalPerf.default 398 388 1.03:1
DropdownManyItemsPerf.default 1431 1401 1.02:1
ListMinimalPerf.default 484 475 1.02:1
MenuMinimalPerf.default 812 794 1.02:1
MenuButtonMinimalPerf.default 1517 1488 1.02:1
RefMinimalPerf.default 215 211 1.02:1
IconMinimalPerf.default 629 618 1.02:1
Text.Fluent 307 302 1.02:1
BoxMinimalPerf.default 325 323 1.01:1
FlexMinimalPerf.default 275 272 1.01:1
LabelMinimalPerf.default 411 406 1.01:1
LoaderMinimalPerf.default 736 727 1.01:1
ReactionMinimalPerf.default 379 376 1.01:1
SplitButtonMinimalPerf.default 3750 3715 1.01:1
Checkbox.Fluent 610 603 1.01:1
Tooltip.Fluent 465 460 1.01:1
AlertMinimalPerf.default 260 259 1:1
ButtonMinimalPerf.default 152 152 1:1
ButtonSlotsPerf.default 600 601 1:1
CarouselMinimalPerf.default 439 439 1:1
DropdownMinimalPerf.default 3361 3366 1:1
ListWith60ListItems.default 1075 1075 1:1
RadioGroupMinimalPerf.default 403 403 1:1
CustomToolbarPrototype.default 3715 3702 1:1
Dialog.Fluent 733 736 1:1
Dropdown.Fluent 3160 3153 1:1
AttachmentMinimalPerf.default 131 132 0.99:1
ChatWithPopoverPerf.default 490 495 0.99:1
EmbedMinimalPerf.default 1874 1899 0.99:1
LayoutMinimalPerf.default 382 386 0.99:1
TextAreaMinimalPerf.default 458 461 0.99:1
ListCommonPerf.default 926 948 0.98:1
ProviderMergeThemesPerf.default 1889 1920 0.98:1
VideoMinimalPerf.default 586 599 0.98:1
ChatMinimalPerf.default 616 632 0.97:1
ListNestedPerf.default 880 906 0.97:1
SliderMinimalPerf.default 1584 1626 0.97:1
TableMinimalPerf.default 381 392 0.97:1
Slider.Fluent 1499 1541 0.97:1
AttachmentSlotsPerf.default 1041 1086 0.96:1
CheckboxMinimalPerf.default 2847 2955 0.96:1
ToolbarMinimalPerf.default 890 925 0.96:1
AvatarMinimalPerf.default 445 470 0.95:1
StatusMinimalPerf.default 639 673 0.95:1
TreeWith60ListItems.default 213 224 0.95:1
Icon.Fluent 624 657 0.95:1
DialogMinimalPerf.default 732 776 0.94:1
ImageMinimalPerf.default 331 355 0.93:1
ProviderMinimalPerf.default 824 888 0.93:1
HeaderSlotsPerf.default 750 854 0.88:1

@layershifter layershifter merged commit 472f361 into master Jul 3, 2020
@layershifter layershifter deleted the chore/no-default-export-p3 branch July 3, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants