Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(babel-make-styles): Bump Linaria versions #20108

Merged
merged 2 commits into from Oct 5, 2021
Merged

fix(babel-make-styles): Bump Linaria versions #20108

merged 2 commits into from Oct 5, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Oct 5, 2021

Bump linaria versions to consume fix callstack/linaria#820

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@ling1726 ling1726 requested review from a team as code owners October 5, 2021 11:33
varholak-peter
varholak-peter approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@varholak-peter varholak-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇮🇱

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 5, 2021 •
edited

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)		 55.059 kB
17.394 kB		 57.532 kB
18.112 kB		 2.473 kB
718 B
react-button
Button		 23.224 kB
7.219 kB		 25.501 kB
7.738 kB		 2.277 kB
519 B
react-button
CompoundButton		 28.481 kB
8.173 kB		 30.758 kB
8.689 kB		 2.277 kB
516 B
react-button
MenuButton		 25.249 kB
7.895 kB		 27.526 kB
8.413 kB		 2.277 kB
518 B
react-button
SplitButton		 30.737 kB
8.955 kB		 33.637 kB
9.597 kB		 2.9 kB
642 B
react-button
ToggleButton		 32.45 kB
7.868 kB		 34.727 kB
8.39 kB		 2.277 kB
522 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 161.95 kB
46.181 kB		 169.173 kB
48.002 kB		 7.223 kB
1.821 kB
react-link
Link		 11.402 kB
4.59 kB		 11.646 kB
4.699 kB		 244 B
109 B
react-menu
Menu (including children components)		 103.316 kB
31.501 kB		 105.789 kB
32.202 kB		 2.473 kB
701 B
react-menu
Menu (including selectable components)		 105.592 kB
31.866 kB		 108.065 kB
32.575 kB		 2.473 kB
709 B
react-slider
RangedSlider		 35.092 kB
10.615 kB		 41.41 kB
11.97 kB		 6.318 kB
1.355 kB
react-slider
Slider		 32.072 kB
10.166 kB		 34.788 kB
10.855 kB		 2.716 kB
689 B
react-switch
Switch		 23.89 kB
7.842 kB		 26.606 kB
8.557 kB		 2.716 kB
715 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar		 54.953 kB
15.667 kB
react-badge
Badge		 23.182 kB
6.986 kB
react-badge
CounterBadge		 25.642 kB
7.682 kB
react-badge
PresenseBadge		 237 B
177 B
react-card
Card - All		 13.471 kB
5.068 kB
react-card
Card		 9.317 kB
3.925 kB
react-card
CardFooter		 8.468 kB
3.557 kB
react-card
CardHeader		 9.695 kB
3.99 kB
react-card
CardPreview		 8.783 kB
3.741 kB
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB
react-divider
Divider		 15.342 kB
5.585 kB
react-image
Image		 9.771 kB
3.975 kB
react-input
Input		 31.319 kB
11.305 kB
react-label
Label		 8.952 kB
3.708 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.175 kB
8.366 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.558 kB
1.204 kB
react-popover
Popover		 101.153 kB
30.37 kB
react-portal
Portal		 6.725 kB
2.237 kB
react-positioning
usePopper		 23.145 kB
7.942 kB
react-provider
FluentProvider		 15.147 kB
5.573 kB
react-text
Text - Default		 11.338 kB
4.418 kB
react-text
Text - Wrappers		 14.407 kB
4.724 kB
react-theme
Teams: all themes		 25.712 kB
6.17 kB
react-theme
Teams: Light theme		 17.215 kB
5.116 kB
react-tooltip
Tooltip		 45.543 kB
15.541 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against af79644942d876c6ffe4656affaa592d766c0cf8

@layershifter layershifter enabled auto-merge (squash) October 5, 2021 11:42
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df787a2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 5, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: af79644942d876c6ffe4656affaa592d766c0cf8 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 788 772 5000
BaseButton mount 803 786 5000
Breadcrumb mount 2236 2283 1000
ButtonNext mount 433 443 5000
Checkbox mount 1324 1326 5000
CheckboxBase mount 1110 1103 5000
ChoiceGroup mount 4011 4028 5000
ComboBox mount 859 845 1000
CommandBar mount 8792 8798 1000
ContextualMenu mount 5572 5555 1000
DefaultButton mount 961 988 5000
DetailsRow mount 3232 3262 5000
DetailsRowFast mount 3216 3235 5000
DetailsRowNoStyles mount 3038 3078 5000
Dialog mount 2114 2128 1000
DocumentCardTitle mount 153 148 1000
Dropdown mount 2735 2764 5000
FluentProviderNext mount 2912 2906 5000
FluentProviderWithTheme mount 181 175 10
FluentProviderWithTheme virtual-rerender 82 86 10
FluentProviderWithTheme virtual-rerender-with-unmount 199 210 10
FocusTrapZone mount 1582 1558 5000
FocusZone mount 1573 1580 5000
IconButton mount 1491 1514 5000
Label mount 307 309 5000
Layer mount 2534 2584 5000
Link mount 414 419 5000
MakeStyles mount 1574 1582 50000
MenuButton mount 1289 1280 5000
MessageBar mount 1731 1748 5000
Nav mount 2850 2834 1000
OverflowSet mount 955 957 5000
Panel mount 2026 2034 1000
Persona mount 716 726 1000
Pivot mount 1237 1236 1000
PrimaryButton mount 1106 1093 5000
Rating mount 6694 6653 5000
SearchBox mount 1166 1154 5000
Shimmer mount 2168 2200 5000
Slider mount 1699 1690 5000
SpinButton mount 4317 4313 5000
Spinner mount 366 380 5000
SplitButton mount 2725 2704 5000
Stack mount 444 440 5000
StackWithIntrinsicChildren mount 1476 1468 5000
StackWithTextChildren mount 3946 3956 5000
SwatchColorPicker mount 8855 8974 5000
Tabs mount 1809 1217 1000
TagPicker mount 2224 2319 5000
TeachingBubble mount 11110 11202 5000
Text mount 373 373 5000
TextField mount 1169 1183 5000
ThemeProvider mount 1052 1030 5000
ThemeProvider virtual-rerender 527 522 5000
ThemeProvider virtual-rerender-with-unmount 1583 1590 5000
Toggle mount 707 701 5000
buttonNative mount 120 114 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 153 135 1.13:1
AvatarMinimalPerf.default 184 165 1.12:1
CustomToolbarPrototype.default 3829 3526 1.09:1
ButtonMinimalPerf.default 154 143 1.08:1
PortalMinimalPerf.default 163 153 1.07:1
TextAreaMinimalPerf.default 433 405 1.07:1
TreeWith60ListItems.default 162 154 1.05:1
CarouselMinimalPerf.default 409 395 1.04:1
ChatWithPopoverPerf.default 330 317 1.04:1
DividerMinimalPerf.default 313 301 1.04:1
ListCommonPerf.default 548 527 1.04:1
TableMinimalPerf.default 342 330 1.04:1
FlexMinimalPerf.default 247 239 1.03:1
GridMinimalPerf.default 296 287 1.03:1
ImageMinimalPerf.default 313 305 1.03:1
ListNestedPerf.default 479 466 1.03:1
LoaderMinimalPerf.default 606 590 1.03:1
SkeletonMinimalPerf.default 305 295 1.03:1
IconMinimalPerf.default 529 515 1.03:1
AnimationMinimalPerf.default 358 351 1.02:1
CardMinimalPerf.default 481 471 1.02:1
ChatDuplicateMessagesPerf.default 261 256 1.02:1
DropdownManyItemsPerf.default 590 576 1.02:1
HeaderSlotsPerf.default 643 632 1.02:1
InputMinimalPerf.default 1134 1115 1.02:1
SliderMinimalPerf.default 1451 1420 1.02:1
AccordionMinimalPerf.default 140 139 1.01:1
AttachmentSlotsPerf.default 940 932 1.01:1
ChatMinimalPerf.default 557 553 1.01:1
DatepickerMinimalPerf.default 4783 4748 1.01:1
DropdownMinimalPerf.default 2725 2695 1.01:1
EmbedMinimalPerf.default 3651 3618 1.01:1
FormMinimalPerf.default 339 336 1.01:1
HeaderMinimalPerf.default 303 301 1.01:1
ItemLayoutMinimalPerf.default 1023 1015 1.01:1
LabelMinimalPerf.default 328 324 1.01:1
ListMinimalPerf.default 434 430 1.01:1
ListWith60ListItems.default 552 544 1.01:1
MenuButtonMinimalPerf.default 1400 1388 1.01:1
ProviderMinimalPerf.default 973 963 1.01:1
RefMinimalPerf.default 206 203 1.01:1
SplitButtonMinimalPerf.default 3625 3580 1.01:1
StatusMinimalPerf.default 566 559 1.01:1
TextMinimalPerf.default 289 287 1.01:1
TooltipMinimalPerf.default 881 874 1.01:1
AlertMinimalPerf.default 226 225 1:1
ButtonOverridesMissPerf.default 1509 1504 1:1
CheckboxMinimalPerf.default 2305 2314 1:1
DialogMinimalPerf.default 642 640 1:1
LayoutMinimalPerf.default 307 308 1:1
ReactionMinimalPerf.default 323 322 1:1
TableManyItemsPerf.default 1599 1593 1:1
ToolbarMinimalPerf.default 788 789 1:1
BoxMinimalPerf.default 291 294 0.99:1
MenuMinimalPerf.default 710 718 0.99:1
RosterPerf.default 1001 1012 0.99:1
PopupMinimalPerf.default 501 504 0.99:1
TreeMinimalPerf.default 667 671 0.99:1
ButtonSlotsPerf.default 475 485 0.98:1
RadioGroupMinimalPerf.default 364 371 0.98:1
SegmentMinimalPerf.default 290 295 0.98:1
VideoMinimalPerf.default 530 547 0.97:1
ProviderMergeThemesPerf.default 1476 1770 0.83:1

@layershifter layershifter merged commit c41b8f8 into microsoft:master Oct 5, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@ling1726
fix(babel-make-styles): Bump Linaria versions (microsoft#20108)
1f87838 
* fix(babel-make-styles): Bump Linaria versions

Bump linaria versions to consume fix callstack/linaria#820

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@varholak-peter varholak-peter varholak-peter approved these changes

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@linaria/shaker: export * is removed for TS
5 participants
@ling1726 @fabricteam @layershifter @varholak-peter @bsunderhus