chore: bump @griffel/* packages #31258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
2 times, most recently
from
4fd297b
to
3dfdb42
Compare
馃搳 Bundle size report
Unchanged fixtures
|
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
2 times, most recently
from
b5ef886
to
9cc495e
Compare
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 630 | 5000 | |
| Button | mount | 313 | 324 | 5000 | |
| Field | mount | 1132 | 1141 | 5000 | |
| FluentProvider | mount | 717 | 725 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 46 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 85 | 78 | 10 | |
| MakeStyles | mount | 854 | 869 | 50000 | |
| Persona | mount | 1779 | 1694 | 5000 | |
| SpinButton | mount | 1378 | 1362 | 5000 | |
| SwatchPicker | mount | 1610 | 1583 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 89 | 80 | 1.11:1 |
| RefMinimalPerf.default | 114 | 104 | 1.1:1 |
| LoaderMinimalPerf.default | 197 | 180 | 1.09:1 |
| PortalMinimalPerf.default | 89 | 82 | 1.09:1 |
| DividerMinimalPerf.default | 224 | 207 | 1.08:1 |
| TextAreaMinimalPerf.default | 288 | 267 | 1.08:1 |
| AccordionMinimalPerf.default | 85 | 80 | 1.06:1 |
| ButtonSlotsPerf.default | 318 | 301 | 1.06:1 |
| DropdownManyItemsPerf.default | 390 | 369 | 1.06:1 |
| AlertMinimalPerf.default | 160 | 152 | 1.05:1 |
| AnimationMinimalPerf.default | 302 | 288 | 1.05:1 |
| BoxMinimalPerf.default | 199 | 190 | 1.05:1 |
| LayoutMinimalPerf.default | 201 | 192 | 1.05:1 |
| SegmentMinimalPerf.default | 197 | 187 | 1.05:1 |
| ButtonMinimalPerf.default | 94 | 90 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 155 | 149 | 1.04:1 |
| DatepickerMinimalPerf.default | 3721 | 3573 | 1.04:1 |
| ImageMinimalPerf.default | 243 | 234 | 1.04:1 |
| ListMinimalPerf.default | 315 | 302 | 1.04:1 |
| TableMinimalPerf.default | 232 | 223 | 1.04:1 |
| TreeMinimalPerf.default | 494 | 477 | 1.04:1 |
| CardMinimalPerf.default | 318 | 308 | 1.03:1 |
| CheckboxMinimalPerf.default | 1154 | 1125 | 1.03:1 |
| ListNestedPerf.default | 326 | 315 | 1.03:1 |
| ProviderMinimalPerf.default | 202 | 196 | 1.03:1 |
| DialogMinimalPerf.default | 450 | 442 | 1.02:1 |
| HeaderMinimalPerf.default | 206 | 202 | 1.02:1 |
| HeaderSlotsPerf.default | 466 | 456 | 1.02:1 |
| MenuButtonMinimalPerf.default | 951 | 931 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2260 | 2205 | 1.02:1 |
| CustomToolbarPrototype.default | 1472 | 1446 | 1.02:1 |
| AttachmentSlotsPerf.default | 631 | 626 | 1.01:1 |
| DropdownMinimalPerf.default | 1432 | 1412 | 1.01:1 |
| InputMinimalPerf.default | 536 | 533 | 1.01:1 |
| ReactionMinimalPerf.default | 214 | 211 | 1.01:1 |
| SliderMinimalPerf.default | 740 | 730 | 1.01:1 |
| StatusMinimalPerf.default | 394 | 389 | 1.01:1 |
| TableManyItemsPerf.default | 1097 | 1086 | 1.01:1 |
| TreeWith60ListItems.default | 84 | 83 | 1.01:1 |
| AvatarMinimalPerf.default | 107 | 107 | 1:1 |
| ChatWithPopoverPerf.default | 192 | 192 | 1:1 |
| EmbedMinimalPerf.default | 1846 | 1853 | 1:1 |
| ItemLayoutMinimalPerf.default | 710 | 708 | 1:1 |
| RadioGroupMinimalPerf.default | 257 | 257 | 1:1 |
| TooltipMinimalPerf.default | 1280 | 1283 | 1:1 |
| ButtonOverridesMissPerf.default | 642 | 649 | 0.99:1 |
| FormMinimalPerf.default | 219 | 222 | 0.99:1 |
| LabelMinimalPerf.default | 218 | 221 | 0.99:1 |
| IconMinimalPerf.default | 396 | 399 | 0.99:1 |
| ToolbarMinimalPerf.default | 543 | 547 | 0.99:1 |
| CarouselMinimalPerf.default | 252 | 258 | 0.98:1 |
| FlexMinimalPerf.default | 152 | 155 | 0.98:1 |
| MenuMinimalPerf.default | 500 | 509 | 0.98:1 |
| SkeletonMinimalPerf.default | 190 | 194 | 0.98:1 |
| VideoMinimalPerf.default | 416 | 426 | 0.98:1 |
| PopupMinimalPerf.default | 350 | 359 | 0.97:1 |
| ProviderMergeThemesPerf.default | 634 | 655 | 0.97:1 |
| RosterPerf.default | 1537 | 1598 | 0.96:1 |
| TextMinimalPerf.default | 195 | 203 | 0.96:1 |
| ListCommonPerf.default | 375 | 394 | 0.95:1 |
| ChatMinimalPerf.default | 433 | 459 | 0.94:1 |
| ListWith60ListItems.default | 354 | 375 | 0.94:1 |
| GridMinimalPerf.default | 175 | 188 | 0.93:1 |
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
from
9cc495e
to
28d417c
Compare
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 642 | 5000 | |
| Breadcrumb | mount | 1754 | 1778 | 1000 | |
| Checkbox | mount | 1702 | 1699 | 5000 | |
| CheckboxBase | mount | 1489 | 1493 | 5000 | |
| ChoiceGroup | mount | 2957 | 2975 | 5000 | |
| ComboBox | mount | 655 | 691 | 1000 | |
| CommandBar | mount | 6781 | 6766 | 1000 | |
| ContextualMenu | mount | 16549 | 16283 | 1000 | |
| DefaultButton | mount | 786 | 798 | 5000 | |
| DetailsRow | mount | 2174 | 2250 | 5000 | |
| DetailsRowFast | mount | 2211 | 2227 | 5000 | |
| DetailsRowNoStyles | mount | 2070 | 2038 | 5000 | |
| Dialog | mount | 2738 | 2691 | 1000 | |
| DocumentCardTitle | mount | 233 | 221 | 1000 | |
| Dropdown | mount | 1981 | 2017 | 5000 | |
| FocusTrapZone | mount | 1154 | 1137 | 5000 | |
| FocusZone | mount | 1114 | 1052 | 5000 | |
| GroupedList | mount | 42629 | 42502 | 2 | |
| GroupedList | virtual-rerender | 20234 | 20448 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52221 | 58463 | 2 | |
| GroupedListV2 | mount | 243 | 234 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 220 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 236 | 238 | 2 | |
| IconButton | mount | 1137 | 1142 | 5000 | |
| Label | mount | 326 | 345 | 5000 | |
| Layer | mount | 2724 | 2743 | 5000 | |
| Link | mount | 401 | 400 | 5000 | |
| MenuButton | mount | 988 | 992 | 5000 | |
| MessageBar | mount | 21947 | 21982 | 5000 | |
| Nav | mount | 2059 | 2061 | 1000 | |
| OverflowSet | mount | 806 | 779 | 5000 | |
| Panel | mount | 1857 | 1773 | 1000 | |
| Persona | mount | 760 | 741 | 1000 | |
| Pivot | mount | 904 | 898 | 1000 | |
| PrimaryButton | mount | 931 | 924 | 5000 | |
| Rating | mount | 4655 | 4658 | 5000 | |
| SearchBox | mount | 904 | 942 | 5000 | |
| Shimmer | mount | 1895 | 1915 | 5000 | |
| Slider | mount | 1310 | 1348 | 5000 | |
| SpinButton | mount | 3035 | 2966 | 5000 | |
| Spinner | mount | 407 | 384 | 5000 | |
| SplitButton | mount | 1937 | 1888 | 5000 | |
| Stack | mount | 409 | 416 | 5000 | |
| StackWithIntrinsicChildren | mount | 876 | 854 | 5000 | |
| StackWithTextChildren | mount | 2616 | 2632 | 5000 | |
| SwatchColorPicker | mount | 6473 | 6420 | 5000 | |
| TagPicker | mount | 1479 | 1502 | 5000 | |
| Text | mount | 374 | 380 | 5000 | |
| TextField | mount | 963 | 981 | 5000 | |
| ThemeProvider | mount | 836 | 838 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 567 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1276 | 1292 | 5000 | |
| Toggle | mount | 607 | 635 | 5000 | |
| buttonNative | mount | 180 | 202 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
馃暤 FluentUIV0 No visual regressions between this PR and main |
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
5 times, most recently
from
86a56f8
to
24aba5f
Compare
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
from
24aba5f
to
2cf18ea
Compare
layershifter
requested review from
Mitch-At-Work,
a team,
tomi-msft,
sopranopillow,
marcosmoura,
mltejera and
smhigley
as code owners
layershifter
requested review from
GeoffCoxMSFT,
khmakoto,
ms-acalzaretto,
chpalac,
ling1726,
behowell,
spmonahan,
micahgodbolt and
a team
as code owners
bsunderhus
approved these changes
May 9, 2024
Hotell
reviewed
May 13, 2024
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
2 times, most recently
from
d9c253c
to
8130bf9
Compare
Hotell
approved these changes
May 14, 2024
|
those bundle size increases will be gone once we migrate to new shorthands api right ? |
@Hotell The increase comes from changes in
|
spmonahan
approved these changes
May 16, 2024
Mitch-At-Work
approved these changes
May 16, 2024
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
from
8130bf9
to
10d8c80
Compare
fabricteam
reviewed
May 17, 2024
fabricteam
reviewed
May 17, 2024
fabricteam
reviewed
May 17, 2024
layershifter
force-pushed
the
chore/bump-griffel-shorthands
branch
from
10d8c80
to
f294ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR bumps
@griffel/*packages to latest.Notable changes
csstypecsstypebump to 3.1.3 causing BREAKING CHANGEs on type-level聽griffel#510@griffel/jest-serializerImprove speed of serializer test function聽griffel#516PR changes
package.jsonfiles & change log files@babel/*packages have been bumped to avoid duplicatespackages/react-components/babel-preset-global-context/src/index.tshave been updated due TS error "types were not portable"shorthands.*()have been deprecated:packages/eslint-plugin/src/configs/core.jshave been temporary updated to exclude to disable deprecation rule for['**/*.stories.tsx', '**/*.styles.ts', '**/*.cy.tsx', '**/*.mixins.ts']packages/react-components/react-calendar-compat/src/utils/animations.tsdisableddeprecation/deprecationpackages/react-components/react-tabster/src/focus/createFocusOutlineStyle.tsdisableddeprecation/deprecationpackages/react-components/theme-designer/src/*disableddeprecation/deprecation@griffel/jest-serializerthat removes trailing spaces:packages/react-components/react-provider/src/components/FluentProvider/FluentProvider-node.test.tsxupdatedpackages/react-components/theme-designer/src/components/ColorTokens/TokenList.styles.tsto have.styles.tssuffix instead ofstyle.tsFollow ups
shorthands.*()聽#31318)deprecation/deprecation(tracked by Run Griffel codemod to remove usage ofshorthands.*()聽#31318)