Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric 7: TypeScript 3.5 Updates (WIP) #9209

Merged
merged 18 commits into from Jun 3, 2019
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/theming-designer/package.json
Expand Up @@ -35,7 +35,7 @@
"office-ui-fabric-react": ">=6.185.0 <7.0.0",
"react": ">=16.8.0 <17.0.0",
"react-dom": ">=16.8.0 <17.0.0",
"typescript": "3.3.3",
"typescript": "3.5.1",
"tslib": "^1.7.1"
}
}
2 changes: 1 addition & 1 deletion apps/todo-app/package.json
Expand Up @@ -30,7 +30,7 @@
"office-ui-fabric-react": "^6.185.0",
"react": ">=16.8.0 <17.0.0",
"react-dom": ">=16.8.0 <17.0.0",
"typescript": "3.3.3",
"typescript": "3.5.1",
"tslib": "^1.7.1"
}
}
2 changes: 1 addition & 1 deletion apps/vr-tests/package.json
Expand Up @@ -46,7 +46,7 @@
"react": ">=16.8.0 <17.0.0",
"react-dom": ">=16.8.0 <17.0.0",
"tslib": "^1.7.1",
"typescript": "3.3.3"
"typescript": "3.5.1",
},
"disabledTasks": [
"verify-api-extractor"
Expand Down
12 changes: 12 additions & 0 deletions common/config/rush/pnpmfile.js
Expand Up @@ -40,6 +40,18 @@ function readPackage(packageJson, context) {
packageJson.dependencies['typescript'] = '^2 || ^3';
}

// TODO: temporary changes to test 3.5.0-rc. delete before fabric 7 release!
if (
packageJson.name === 'fork-ts-checker-webpack-plugin' ||
packageJson.name === 'riceburn' ||
packageJson.name === 'tslint-microsoft-contrib' ||
packageJson.name === 'tslint' ||
packageJson.name === 'tslint-react' ||
packageJson.name === 'tsutils'
) {
packageJson.dependencies['typescript'] = '3.5.0-dev.20190525';
}

// Example: Suppose the karma types have a missing dependency on typings from the log4js package.
// if (packageJson.name === '@types/karma') {
// context.log('Fixed up dependencies for @types/karma');
Expand Down