Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arity Checks for Command Parameters in Garnet #138

Closed
wants to merge 7 commits into from

Conversation

argsno
Copy link
Contributor

@argsno argsno commented Mar 26, 2024

It has been noticed that the current implementation of checking parameters in each command is independent.
Furthermore, some commands were previously implemented incorrectly
and did not drain commands as they were supposed to, but this has been fixed as mentioned in https://github.com/microsoft/garnet/pull/103/files.

However, it is still necessary to check the parameters for each command
that may be constrained by arity.

Therefore, this pull request adds an arity check for each command.

@TalZaccai
Copy link
Contributor

Hi! We've reviewed your PR and found that while the problem of arity values not being checked is correctly identified, this solution is unfortunately insufficient. We have added this work item to our list and will get to resolving it soon. Thank you for your contribution!

@TalZaccai TalZaccai closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants