Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate tools dependencies in tools package #293

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Jul 21, 2023

Use ./tools to prevent callers of go-winio from needing to add tools to their dependencies.

Similar to microsoft/hcsshim#1840

Also update dependencies

Use `./tools` to prevent callers of `go-winio` from needing to add tools
to their dependencies.

Similar to microsoft/hcsshim#1840

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy requested a review from a team as a code owner July 21, 2023 19:15
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helsaawy helsaawy merged commit 10d5703 into microsoft:main Jul 21, 2023
8 checks passed
@helsaawy helsaawy deleted the tools-pkg branch July 21, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants