Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with loading css/scsss #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LokiMidgard
Copy link

As long as the localIdentName was set in the parameter the modules parameter was ignored. This resulted in the use of modules even when modules was set to false explicitly

Overview

Fixes #343

The problem was introduced in #243. It fixed a problem with invalid options, but always set the module option for the css-loader.
This prevented the styles to get applied since the name of the style was changed in the css but not in the DOM.

Test Notes

As long as the `localIdentName` was set in the parameter the modules parameter was ignored. This resulted in the use of modules even when modules was set to false explicitly
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! You'll also need to run yarn change to generate a change file.

@LokiMidgard
Copy link
Author

@ecraig12345 is it possible to crate this file manual?
I'm not very keen on installing a bunch of dependency's on my machine, I will probably never use again, just to add an additional check to one if.

@ecraig12345
Copy link
Member

@LokiMidgard Maybe, but it would probably be easier to just clone the repo, yarn, yarn change, then delete it when you're done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css loader invalid options in stylesOverlay.js
2 participants