Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle diagnostics object in EmitOutput #4466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle diagnostics object in EmitOutput #4466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd977b8
fix: handle diagnostics object in getEmitOutput
Carlosamouco Apr 10, 2024
fcd2154
Merge branch 'main' into patch-1
Carlosamouco Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/language/typescript/tsWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,16 @@ export class TypeScriptWorker implements ts.LanguageServiceHost, ITypeScriptWork
if (fileNameIsLib(fileName)) {
return { outputFiles: [], emitSkipped: true };
}
return this._languageService.getEmitOutput(fileName);
const emitOutput = this._languageService.getEmitOutput(fileName);

// 'diagnostics' object is internal in ts.EmitOutput
if ('diagnostics' in emitOutput) {
emitOutput.diagnostics = TypeScriptWorker.clearFiles(
emitOutput.diagnostics as ts.Diagnostic[]
);
}

return emitOutput;
}

async getCodeFixesAtPosition(
Expand Down