Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Max MTU to 4096 #3247

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Increase Max MTU to 4096 #3247

wants to merge 2 commits into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Nov 22, 2022

Description

Trying out what happens with larger MTUs

Testing

Automation

Documentation

None

@nibanks nibanks added Area: Core Related to the shared, core protocol logic Area: Performance labels Nov 22, 2022
@nibanks
Copy link
Member Author

nibanks commented Nov 22, 2022

/azp run perf

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #3247 (6f6c286) into main (649f971) will decrease coverage by 0.33%.
Report is 1 commits behind head on main.
The diff coverage is 79.86%.

@@            Coverage Diff             @@
##             main    #3247      +/-   ##
==========================================
- Coverage   86.84%   86.51%   -0.33%     
==========================================
  Files          56       56              
  Lines       16712    16854     +142     
==========================================
+ Hits        14513    14582      +69     
- Misses       2199     2272      +73     
Files Coverage Δ
src/core/connection.c 81.84% <ø> (+0.03%) ⬆️
src/core/loss_detection.c 89.84% <100.00%> (+0.06%) ⬆️
src/core/send.c 88.87% <ø> (ø)
src/core/send.h 87.93% <ø> (ø)
src/core/sent_packet_metadata.c 100.00% <100.00%> (ø)
src/core/sent_packet_metadata.h 100.00% <ø> (ø)
src/core/stream_set.c 94.26% <ø> (-0.32%) ⬇️
src/core/frame.c 87.32% <60.00%> (-0.22%) ⬇️
src/core/stream.h 92.03% <75.00%> (-1.30%) ⬇️
src/core/stream_send.c 94.78% <90.47%> (-0.52%) ⬇️
... and 2 more

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic Area: Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant