Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msquichelper.h: suppress GCC stringop-overflow warning #3949

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwhited
Copy link
Contributor

@jwhited jwhited commented Oct 30, 2023

Updates #3918

Description

Builds fail on Linux with more recent versions of GCC (12/13) due to:

/home/jwhited/msquic/src/inc/msquichelper.h:268:28: error: writing 16 bytes into a region of size 0 [-Werror=stringop-overflow=]
  268 |         HexString[i*2 + 1] = HEX_TO_CHAR(Buffer[i] & 0xf);

This PR suppresses that warning as it is likely a false positive.

Testing

N/A

Documentation

N/A

Updates microsoft#3918

Signed-off-by: Jordan Whited <jordan@tailscale.com>
nibanks
nibanks previously approved these changes Oct 30, 2023
@nibanks
Copy link
Member

nibanks commented Oct 30, 2023

/Users/runner/work/msquic/msquic/src/inc/msquichelper.h:269:32: error: unknown warning group '-Wstringop-overflow', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wstringop-overflow"
                               ^

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #3949 (8ae642b) into main (136b175) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3949      +/-   ##
==========================================
- Coverage   86.69%   86.42%   -0.28%     
==========================================
  Files          56       56              
  Lines       16901    16901              
==========================================
- Hits        14653    14607      -46     
- Misses       2248     2294      +46     

see 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants