draft km xdp proto #4023
Draft
draft km xdp proto #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Dec 28, 2023
scripts/performance.ps1
Outdated
Comment on lines
320
to
327
| $CurrentCommitHash = Get-GitHash -RepoDir $RootDir | ||
| $CurrentCommitDate = Get-CommitDate -RepoDir $RootDir | ||
| # $CurrentCommitHash = Get-GitHash -RepoDir $RootDir | ||
| # $CurrentCommitDate = Get-CommitDate -RepoDir $RootDir |
nibanks
reviewed
Dec 28, 2023
scripts/performance.ps1
Outdated
| @@ -314,11 +319,12 @@ if ($Local) { | |||
| $RemoteDirectory = Invoke-TestCommand -Session $Session -ScriptBlock { | |||
| Join-Path (Get-Location) "Tests" | |||
| } | |||
| $RemoteDirectory = "C:\msquic\artifacts\bin" | |||
nibanks
reviewed
Dec 28, 2023
scripts/performance.ps1
Outdated
| @@ -365,34 +371,34 @@ function LocalTeardown { | |||
| $RemoteExePath = Get-ExePath -PathRoot $RemoteDirectory -Platform $RemotePlatform -IsRemote $true | |||
| $LocalExePath = Get-ExePath -PathRoot $LocalDirectory -Platform $LocalPlatform -IsRemote $false | |||
|
|
|||
| # See if we are an AZP PR | |||
There was a problem hiding this comment.
Revert this please, as well as all other changes like this
nibanks
reviewed
Dec 28, 2023
Comment on lines
+464
to
+466
| if (TimeoutMs == 0xffffffff) { | ||
| return KeWaitForSingleObject(Event, Executive, KernelMode, FALSE, NULL); | ||
| } else { |
There was a problem hiding this comment.
Why is this necessary? It shouldn't call this function if it's not waiting with a timeout.
nibanks
reviewed
Dec 28, 2023
|
|
||
| if (IsListEmpty(&queue->Events)) { | ||
| CxPlatDispatchLockRelease(&queue->Lock); | ||
| CxPlatEventWaitWithTimeout(queue->EventsAvailable, wait_time); |
There was a problem hiding this comment.
If wait_time is zero, then we shouldn't lock again.
nibanks
reviewed
Dec 28, 2023
src/perf/lib/HpsClient.cpp
Outdated
| @@ -10,6 +10,7 @@ | |||
| --*/ | |||
|
|
|||
| #include "HpsClient.h" | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
All these changes should be unnecessary in the latest version of secnetperf.
nibanks
reviewed
Dec 28, 2023
Comment on lines
+321
to
+325
| if (Status == QUIC_STATUS_PENDING) { | ||
| return QUIC_STATUS_PENDING; | ||
| } else { | ||
| return Status; | ||
| } |
There was a problem hiding this comment.
Can't you just always return Status?
nibanks
reviewed
Dec 28, 2023
| @@ -221,6 +221,9 @@ CxPlatWorkersLazyStart( | |||
| for (uint32_t i = 0; i < CxPlatWorkerCount; ++i) { | |||
| if (CxPlatWorkers[i].InitializedThread) { | |||
| CxPlatWorkers[i].StoppingThread = TRUE; | |||
| // QuicTraceLogInfo( | |||
There was a problem hiding this comment.
Most of these are just commented out code. Remove?
This reverts commit 9457dd2.
nigriMSFT
force-pushed
the
nigriMSFT/km-xdp-proto
branch
from
fa78ca9
to
37e1b3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
==========================================
+ Coverage 86.17% 86.85% +0.67%
==========================================
Files 56 56
Lines 16953 16929 -24
==========================================
+ Hits 14610 14704 +94
+ Misses 2343 2225 -118 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?