Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi config generators on all platforms #4156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

behda
Copy link
Contributor

@behda behda commented Feb 24, 2024

Description

Build Openssl debug and release variants in separate directories to better support multi config generators (like ninja) on all platforms.

Testing

Do any existing tests cover this change? Are new tests needed? Don't think so.

Documentation

Is there any documentation impact for this change? Don't think so.

@behda behda requested a review from a team as a code owner February 24, 2024 19:41
@behda
Copy link
Contributor Author

behda commented Feb 24, 2024

@behda please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@nibanks nibanks added Area: Build external Proposed by non-MSFT labels Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (86e08e5) to head (069a289).
Report is 54 commits behind head on main.

❗ Current head 069a289 differs from pull request most recent head f3fac5b. Consider uploading reports for the commit f3fac5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4156       +/-   ##
===========================================
- Coverage   87.38%   65.44%   -21.94%     
===========================================
  Files          56       56               
  Lines       16984    15189     -1795     
===========================================
- Hits        14841     9941     -4900     
- Misses       2143     5248     +3105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks
Copy link
Member

nibanks commented Feb 26, 2024

@behda lots of automation failed. Please have a look.

@behda
Copy link
Contributor Author

behda commented Feb 26, 2024

@nibanks there were problems with Darwin builds and generated empty paths, hopefully fixed now. Can't verify myself as I don't have a Mac with me.

@behda
Copy link
Contributor Author

behda commented Feb 26, 2024

Looks like update to minimal cmake 3.20 is needed. Is it acceptable?

@nibanks
Copy link
Member

nibanks commented Feb 28, 2024

Looks like the Docker build failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants