New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi config generators on all platforms #4156
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
===========================================
- Coverage 87.38% 65.44% -21.94%
===========================================
Files 56 56
Lines 16984 15189 -1795
===========================================
- Hits 14841 9941 -4900
- Misses 2143 5248 +3105 ☔ View full report in Codecov by Sentry. |
@behda lots of automation failed. Please have a look. |
@nibanks there were problems with Darwin builds and generated empty paths, hopefully fixed now. Can't verify myself as I don't have a Mac with me. |
Looks like update to minimal cmake 3.20 is needed. Is it acceptable? |
Looks like the Docker build failed. |
Description
Build Openssl debug and release variants in separate directories to better support multi config generators (like ninja) on all platforms.
Testing
Do any existing tests cover this change? Are new tests needed? Don't think so.
Documentation
Is there any documentation impact for this change? Don't think so.