Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Priority Work on Connections #4279

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 3, 2024

Description

Sometimes an application would like to prefer new work over existing work already queued on the connection. This PR adds the notion of priority to the connection's operation queue, and exposes flags through the API to allow the app to chose to leverage this.

Testing

SpinQuic updated.
Need to add some explicit BVTs.

Documentation

TODO

src/core/operation.c Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.22%. Comparing base (bc4454f) to head (1f22fa1).
Report is 2 commits behind head on main.

Files Patch % Lines
src/core/api.c 90.90% 2 Missing ⚠️
src/core/connection.c 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4279      +/-   ##
==========================================
+ Coverage   84.23%   85.22%   +0.98%     
==========================================
  Files          56       56              
  Lines       15382    15424      +42     
==========================================
+ Hits        12957    13145     +188     
+ Misses       2425     2279     -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtfriesen
mtfriesen previously approved these changes May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants