Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock tx/rx/cq/fq for multi thread (multi Connection) #4291

Merged
merged 2 commits into from
May 15, 2024

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented May 8, 2024

Description

secnetperf 100 connections test caused system to completely hang. It requires to reboot the system.
Each ring need to be locked when accessed by multi thread as it is single producer and single consumer.
https://www.kernel.org/doc/html/v5.18/networking/af_xdp.html#rings

Testing

see automation.
secnetperf 100 connections test can avoid the crash. locally tested several times. (There is segfault yet sometimes.)

Documentation

Is there any documentation impact for this change?

@ami-GS ami-GS requested a review from a team as a code owner May 8, 2024 23:28
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (0576776) to head (e1dd136).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4291      +/-   ##
==========================================
- Coverage   84.31%   84.30%   -0.02%     
==========================================
  Files          56       56              
  Lines       15382    15382              
==========================================
- Hits        12970    12968       -2     
- Misses       2412     2414       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nibanks
nibanks previously approved these changes May 15, 2024
@ami-GS ami-GS merged commit 07e4f8b into main May 15, 2024
350 of 355 checks passed
@ami-GS ami-GS deleted the dev/daiki/xdp_lock_queues branch May 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants