[webui] eslint fix #1864

lvybriage · 2019-12-19T11:36:39Z

disable react/disable-name in eslint. 参考issue
update azure-pipelines.yml to enable webui eslint
had specify the rule, such as // eslint-disable-line @typescript-eslint/camelcase
render() : any change to render() : React.ReactNode
// eslint-disable-line @... , @..., @...
change more accuracy function type

~~Still have seven errors to fix & test~~

chicm-ms · 2019-12-20T03:49:03Z

src/webui/src/App.tsx

@@ -27,15 +27,15 @@ class App extends React.Component<{}, AppState> {
        };
    }

-    async componentDidMount() {
+    async componentDidMount(): Promise<any> {


This should be Promise since there is no return value.

Thanks. Had changed Promise<any> to Promise<void>.

chicm-ms · 2019-12-20T07:20:21Z

src/webui/src/components/Modal/Compare.tsx

@@ -20,7 +20,7 @@ class Compare extends React.Component<CompareProps, {}> {
        super(props);
    }

-    intermediate = () => {
+    intermediate = (): any => {


what is the object type of the return value?

It's hard to ensure its type.
I try HTMLElement Element HTMLDivElement.
all tooltip this error: Type 'Element' is missing the following properties from type 'HTMLDivElement': align, addEventListener, removeEventListener, accessKey, and 238 more.ts(2740)

Have you tried React.ReactNode?

chicm-ms · 2019-12-20T07:21:51Z

src/webui/src/components/SlideBar.tsx

@@ -189,15 +189,15 @@ class SlideBar extends React.Component<SliderProps, SliderState> {
        );
    }

-    fresh = (event: React.SyntheticEvent<EventTarget>) => {
+    fresh = (event: React.SyntheticEvent<EventTarget>): any => {


this should be void

chicm-ms · 2019-12-20T07:23:20Z

src/webui/src/components/overview/Accuracy.tsx

@@ -21,7 +21,7 @@ class Accuracy extends React.Component<AccuracyProps, {}> {

    }

-    render() {
+    render(): any { // eslint-disable-line


should specify the rule being disabled.

chicm-ms · 2019-12-20T07:23:54Z

src/webui/src/components/overview/Progress.tsx

        this.setState({ isShowLogDrawer: false });
    }

-    render() {
+    render(): any { // eslint-disable-line


specify the rule being disabled

Oh, when add the any type, it doesn't need to add the note. I'll delete all the similar questions. Thanks!

chicm-ms · 2019-12-20T10:11:24Z

please update azure-pipelines.yml to enable webui eslint

chicm-ms · 2019-12-20T10:16:12Z

src/webui/src/components/Overview.tsx

        const { trialConcurrency } = this.state;
        const { experimentUpdateBroadcast, metricGraphMode } = this.props;

        const searchSpace = this.convertSearchSpace();

        const bestTrials = this.findBestTrials();
-        const bestAccuracy = bestTrials.length > 0 ? bestTrials[0].accuracy! : NaN;
+        const bestAccuracy = bestTrials.length > 0 ? bestTrials[0].accuracy! : ''; // eslint-disable-line


when // eslint-disable-line is used, please specify the rule such as // eslint-disable-line @typescript-eslint/camelcase, so that we know which rule is disabled

lvybriage · 2019-12-20T10:21:51Z

azure-pipelines.yml

OK.

liuzhe-lz · 2019-12-23T08:06:10Z

src/webui/src/components/Modal/Compare.tsx

@@ -52,14 +52,14 @@ class Compare extends React.Component<CompareProps, {}> {
            tooltip: {
                trigger: 'item',
                enterable: true,
-                position: function (point: Array<number>, data: TooltipForIntermediate) {
+                position: function (point: Array<number>, data: TooltipForIntermediate): Array<number> {


Array<number> is more oftenly written as number[].

liuzhe-lz · 2019-12-23T08:07:00Z

src/webui/src/App.tsx

        this.setState({ metricGraphMode: val });
    }

-    render() {
+    render(): any{


Can the return type be React.ReactNode?

It's right!

liuzhe-lz · 2019-12-23T08:10:22Z

src/webui/src/components/TrialsDetail.tsx

@@ -60,55 +60,57 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
            tablePageSize: 20,
            whichGraph: '1',
            searchType: 'id',
-            searchFilter: trial => true,
+            // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+            searchFilter: trial => true // eslint-disable-line @typescript-eslint/no-unused-vars


This two disabling should be merged.

Had fixed, thanks~

liuzhe-lz · 2019-12-23T08:12:45Z

src/webui/src/components/TrialsDetail.tsx

        if (!targetValue.trim()) {
            this.setState({ searchFilter: filter });
            return;
        }
        switch (this.state.searchType) {
            case 'id':
-                filter = trial => trial.info.id.toUpperCase().includes(targetValue.toUpperCase());
+                filter = (trial): any => trial.info.id.toUpperCase().includes(targetValue.toUpperCase()); // elint-disable-line


The return type is boolean.
elint-disable-line does nothing I suppose.

Had fixed. Thanks~

liuzhe-lz · 2019-12-23T08:15:00Z

src/webui/src/components/overview/Progress.tsx

@@ -98,6 +101,8 @@ class Progressed extends React.Component<ProgressProps, ProgressState> {
                </div>
            );
        }
+
+        const bestFinalResult = (typeof bestAccuracy === 'number') ? bestAccuracy.toFixed(6) : '--'; 


Accuracy might be NaN (which is a number) in next release.
No need to fix now though.

I'll change origin code back. And then add // eslint-disable-line @...

liuzhe-lz · 2019-12-23T08:17:19Z

src/webui/src/components/public-child/OpenRow.tsx

@@ -73,10 +73,17 @@ class OpenRow extends React.Component<OpenRowProps, OpenRowState> {
                                    Trails for multiphase experiment will return a set of parameters,
                                    we are listing the latest parameter in webportal.
                                    <br />
-                                    For the entire parameter set, please refer to the following "
-                                    <a href={trialLink} target="_blank">{trialLink}</a>".
+                                    For the entire parameter set, please refer to the following&quot;


space before "?

… acccuracy type

deshui added 2 commits December 19, 2019 19:32

fix eslint

725c472

not check react/disable-name

0c4d8d9

lvybriage changed the title ~~fix eslint~~ [Webui] eslint fix Dec 20, 2019

lvybriage changed the title ~~[Webui] eslint fix~~ [webui] eslint fix Dec 20, 2019

chicm-ms reviewed Dec 20, 2019

View reviewed changes

deshui added 2 commits December 20, 2019 12:46

change promise<any> to promise<void>

e2a9db5

promise

60fa3a7

scarlett2018 mentioned this pull request Dec 20, 2019

Iteration Plan for Dec 2019 #1794

Closed

44 tasks

chicm-ms reviewed Dec 20, 2019

View reviewed changes

leckie-chn requested a review from liuzhe-lz December 20, 2019 08:33

chicm-ms reviewed Dec 20, 2019

View reviewed changes

fix comments by chicm-ms

4c5fe45

chicm-ms approved these changes Dec 22, 2019

View reviewed changes

liuzhe-lz reviewed Dec 23, 2019

View reviewed changes

change render type to React.ReactNode and merge eslint rules and more…

336409b

… acccuracy type

liuzhe-lz approved these changes Dec 23, 2019

View reviewed changes

deshui added 2 commits December 23, 2019 17:13

change Array<number> to number[]

1ce7067

delete unuseful eslint note

0cdfa8a

leckie-chn merged commit 56be400 into microsoft:master Dec 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webui] eslint fix #1864

[webui] eslint fix #1864

lvybriage commented Dec 19, 2019 •

edited

chicm-ms Dec 20, 2019

lvybriage Dec 20, 2019

chicm-ms Dec 20, 2019 •

edited

lvybriage Dec 20, 2019 •

edited

liuzhe-lz Dec 23, 2019

chicm-ms Dec 20, 2019

lvybriage Dec 20, 2019

chicm-ms Dec 20, 2019

lvybriage Dec 20, 2019

chicm-ms Dec 20, 2019

lvybriage Dec 20, 2019 •

edited

chicm-ms commented Dec 20, 2019

chicm-ms Dec 20, 2019

lvybriage Dec 20, 2019

lvybriage commented Dec 20, 2019

liuzhe-lz Dec 23, 2019

lvybriage Dec 23, 2019

liuzhe-lz Dec 23, 2019

lvybriage Dec 23, 2019

liuzhe-lz Dec 23, 2019

lvybriage Dec 23, 2019

liuzhe-lz Dec 23, 2019 •

edited

lvybriage Dec 23, 2019

liuzhe-lz Dec 23, 2019 •

edited

lvybriage Dec 23, 2019

liuzhe-lz Dec 23, 2019

lvybriage Dec 23, 2019

[webui] eslint fix #1864

[webui] eslint fix #1864

Conversation

lvybriage commented Dec 19, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chicm-ms Dec 20, 2019 • edited

Choose a reason for hiding this comment

lvybriage Dec 20, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lvybriage Dec 20, 2019 • edited

Choose a reason for hiding this comment

chicm-ms commented Dec 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lvybriage commented Dec 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuzhe-lz Dec 23, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuzhe-lz Dec 23, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lvybriage commented Dec 19, 2019 •

edited

chicm-ms Dec 20, 2019 •

edited

lvybriage Dec 20, 2019 •

edited

lvybriage Dec 20, 2019 •

edited

liuzhe-lz Dec 23, 2019 •

edited

liuzhe-lz Dec 23, 2019 •

edited