Skip to content

Commit

Permalink
fix(types): allow any return type from event handlers (#30492)
Browse files Browse the repository at this point in the history
Closes #29353.
  • Loading branch information
dgozman committed Apr 24, 2024
1 parent b1d963c commit 8fc7723
Show file tree
Hide file tree
Showing 6 changed files with 281 additions and 291 deletions.
2 changes: 0 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ test/assets/modernizr.js
/packages/playwright-core/types/*
/packages/playwright-ct-core/src/generated/*
/index.d.ts
utils/generate_types/overrides.d.ts
utils/generate_types/test/test.ts
node_modules/
browser_patches/*/checkout/
browser_patches/chromium/output/
Expand Down
4 changes: 1 addition & 3 deletions docs/src/api/class-page.md
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,7 @@ Emitted when a JavaScript dialog appears, such as `alert`, `prompt`, `confirm` o
**Usage**

```js
page.on('dialog', dialog => {
dialog.accept();
});
page.on('dialog', dialog => dialog.accept());
```

```java
Expand Down

0 comments on commit 8fc7723

Please sign in to comment.