chore: bump packages + fix tsc and formatting

microsoft · May 9, 2024 · 91c7319 · 91c7319
1 parent 2894096
commit 91c7319
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 20 deletions.
diff --git a/packages/playwright-ct-angular/.npmignore b/packages/playwright-ct-angular/.npmignore
@@ -2,6 +2,7 @@
 
 !README.md
 !LICENSE
+!cli.js
 !register.d.ts
 !register.mjs
 !registerSource.mjs

diff --git a/packages/playwright-ct-angular/index.d.ts b/packages/playwright-ct-angular/index.d.ts
@@ -35,14 +35,12 @@ export interface MountResult<Component> extends Locator {
   }): Promise<void>;
 }
 
-export interface ComponentFixtures {
+export const test: TestType<{
   mount<HooksConfig extends JsonObject, Component = unknown>(
     component: Type<Component>,
     options?: MountOptions<HooksConfig, Component>
   ): Promise<MountResult<Component>>;
-}
-
-export const test: TestType<ComponentFixtures>;
+}>;
 
 export { defineConfig, PlaywrightTestConfig } from '@playwright/experimental-ct-core';
 export { expect, devices } from 'playwright/test';
diff --git a/packages/playwright-ct-angular/register.d.ts b/packages/playwright-ct-angular/register.d.ts
@@ -14,4 +14,4 @@
  * limitations under the License.
  */
 
-export default function pwRegister(components: Record<string, any>): void
+export default function pwRegister(components: Record<string, any>): void;
diff --git a/tests/components/ct-angular/package.json b/tests/components/ct-angular/package.json
@@ -11,23 +11,23 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@analogjs/vite-plugin-angular": "1.0.2",
-    "@angular/animations": "17.3.1",
-    "@angular/common": "17.3.1",
-    "@angular/compiler": "17.3.1",
-    "@angular/core": "17.3.1",
-    "@angular/forms": "17.3.1",
-    "@angular/platform-browser": "17.3.1",
-    "@angular/platform-browser-dynamic": "17.3.1",
-    "@angular/router": "17.3.1",
+    "@analogjs/vite-plugin-angular": "1.3.0",
+    "@angular/animations": "17.3.8",
+    "@angular/common": "17.3.8",
+    "@angular/compiler": "17.3.8",
+    "@angular/core": "17.3.8",
+    "@angular/forms": "17.3.8",
+    "@angular/platform-browser": "17.3.8",
+    "@angular/platform-browser-dynamic": "17.3.8",
+    "@angular/router": "17.3.8",
     "rxjs": "7.8.1",
     "tslib": "2.6.2",
-    "zone.js": "0.14.4"
+    "zone.js": "0.14.5"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "17.3.2",
-    "@angular/cli": "17.3.2",
-    "@angular/compiler-cli": "17.3.1",
+    "@angular-devkit/build-angular": "17.3.7",
+    "@angular/cli": "17.3.7",
+    "@angular/compiler-cli": "17.3.8",
     "typescript": "5.4.3"
   }
 }
diff --git a/tests/components/ct-angular/playwright.config.mts b/tests/components/ct-angular/playwright.config.mts
@@ -22,13 +22,17 @@ export default defineConfig({
   testDir: 'tests',
   forbidOnly: !!process.env['CI'],
   retries: process.env['CI'] ? 2 : 0,
-  reporter: 'html',
+  reporter: process.env['CI'] ? 'html' : 'line',
   use: {
     trace: 'on-first-retry',
     ctViteConfig: {
       plugins: [angular({
         tsconfig: resolve('./tsconfig.spec.json'),
-      })],
+        /**
+         * TODO: remove any and resolve conflicting @angular-devkit/build-angular and
+         * and @playwright-ct-core vite versions
+         */
+      }) as any],
       resolve: {
         alias: {
           '@': resolve('./src'),

diff --git a/tests/components/ct-angular/tsconfig.json b/tests/components/ct-angular/tsconfig.json
@@ -11,6 +11,7 @@
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
     "sourceMap": true,
+    "skipLibCheck": true,
     "declaration": false,
     "downlevelIteration": true,
     "experimentalDecorators": true,