Skip to content

Commit

Permalink
chore: allow stub JSX instances in type module (#23211)
Browse files Browse the repository at this point in the history
Fixes #23207
  • Loading branch information
pavelfeldman committed May 22, 2023
1 parent e872a2b commit ee38649
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/playwright-test/jsx-runtime.js
Expand Up @@ -28,7 +28,10 @@ function jsxs(type, props) {
};
}

const Fragment = {};

module.exports = {
Fragment,
jsx,
jsxs,
};
21 changes: 21 additions & 0 deletions packages/playwright-test/jsx-runtime.mjs
@@ -0,0 +1,21 @@
/**
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import jsxRuntime from './jsx-runtime.js';

export const jsx = jsxRuntime.jsx;
export const jsxs = jsxRuntime.jsxs;
export const Fragment = jsxRuntime.Fragment;
6 changes: 5 additions & 1 deletion packages/playwright-test/package.json
Expand Up @@ -22,7 +22,11 @@
"./lib/internalsForTest": "./lib/internalsForTest.js",
"./lib/experimentalLoader": "./lib/experimentalLoader.js",
"./lib/plugins": "./lib/plugins/index.js",
"./jsx-runtime": "./jsx-runtime.js",
"./jsx-runtime": {
"import": "./jsx-runtime.mjs",
"require": "./jsx-runtime.js",
"default": "./jsx-runtime.js"
},
"./lib/util": "./lib/util.js",
"./lib/utilsBundle": "./lib/utilsBundle.js",
"./reporter": "./reporter.js"
Expand Down
28 changes: 28 additions & 0 deletions tests/playwright-test/loader.spec.ts
Expand Up @@ -488,6 +488,34 @@ test('should load a jsx/tsx files', async ({ runInlineTest }) => {
expect(exitCode).toBe(0);
});

test('should load a jsx/tsx files in ESM mode', async ({ runInlineTest }) => {
const { exitCode, passed } = await runInlineTest({
'package.json': JSON.stringify({
type: 'module'
}),
'playwright.config.ts': `
import { defineConfig } from '@playwright/test';
export default defineConfig({ projects: [{name: 'foo'}] });
`,
'a.spec.tsx': `
import { test, expect } from '@playwright/test';
const component = () => <div></div>;
test('succeeds', () => {
expect(1 + 1).toBe(2);
});
`,
'b.spec.jsx': `
import { test, expect } from '@playwright/test';
const component = () => <div></div>;
test('succeeds', () => {
expect(1 + 1).toBe(2);
});
`
});
expect(passed).toBe(2);
expect(exitCode).toBe(0);
});

test('should load jsx with top-level component', async ({ runInlineTest }) => {
const { exitCode, passed } = await runInlineTest({
'a.spec.tsx': `
Expand Down

0 comments on commit ee38649

Please sign in to comment.