Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proxy): unify local network proxy behavior #10719

Merged
merged 9 commits into from Dec 10, 2021
Merged

feat(proxy): unify local network proxy behavior #10719

merged 9 commits into from Dec 10, 2021

Commits on Dec 8, 2021

  1. feat(proxy): unify local network proxy behavior 

    When configuring a proxy, Chromium requires a magic tokens to get some
local network requests to go through the proxy. This has tripped up a
few users, so we make the behavior default to the expected: proxy
everything including the local requests. This matches the other vendors
as well.

NB: This can be disabled via
`PLAYWRIGHT_DISABLE_FORCED_CHROMIUM_PROXIED_LOOPBACK=1`

Supercedes: microsoft#8345
Fixes: microsoft#10631
    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    25723df View commit details
    Browse the repository at this point in the history

  2. tests: workaround FF exploding on newPage b/c of contile.services.moz… 

    …illa.com
    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    9afea15 View commit details
    Browse the repository at this point in the history

  3. tests: ensure explicit bypasses still work, parallelize

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    75c56c2 View commit details
    Browse the repository at this point in the history

  4. tests: account for WK linux vs. macOS diffs

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    c57eb5e View commit details
    Browse the repository at this point in the history

  5. nit: reduce fail complexity, parameterized -> copy paste

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8eda600 View commit details
    Browse the repository at this point in the history

  6. Revert "nit: reduce fail complexity, parameterized -> copy paste" 

    This reverts commit d307a87.
    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    6560bdf View commit details
    Browse the repository at this point in the history

  7. nit: remove explicit parallel calls

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    b69660c View commit details
    Browse the repository at this point in the history

  8. tests: skip attempting to filter connect requests

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    b755031 View commit details
    Browse the repository at this point in the history

  9. tests: windows did something mac couldn't do!

    @rwoll
    rwoll committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    2f8aeb0 View commit details
    Browse the repository at this point in the history