fix(parallel): minimize the number of beforeAll/afterAll hooks in parallel mode #13138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allel mode Previously, we always formed groups consisting of a single test. Now, we group tests that share `beforeAll`/`afterAll` hooks into `config.workers` equally-sized groups.
pavelfeldman
approved these changes
Mar 28, 2022
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Mar 28, 2022
…eforeAll/afterAll hooks in parallel mode Previously, we always formed groups consisting of a single test. Now, we group tests that share `beforeAll`/`afterAll` hooks into `config.workers` equally-sized groups.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Mar 29, 2022
…eforeAll/afterAll hooks in parallel mode Previously, we always formed groups consisting of a single test. Now, we group tests that share `beforeAll`/`afterAll` hooks into `config.workers` equally-sized groups.
dgozman
added a commit
that referenced
this pull request
Mar 29, 2022
…afterAll hooks in parallel mode (#13140) Previously, we always formed groups consisting of a single test. Now, we group tests that share `beforeAll`/`afterAll` hooks into `config.workers` equally-sized groups.
liuxingbaoyu
pushed a commit
to liuxingbaoyu/playwright
that referenced
this pull request
Mar 30, 2022
…allel mode (microsoft#13138) Previously, we always formed groups consisting of a single test. Now, we group tests that share `beforeAll`/`afterAll` hooks into `config.workers` equally-sized groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we always formed groups consisting of a single test. Now, we group tests that share
beforeAll/afterAllhooks intoconfig.workersequally-sized groups.Fixes #13099.