Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-runner): multiple webServer types #15901

Merged
merged 2 commits into from
Jul 25, 2022
Merged

fix(test-runner): multiple webServer types #15901

merged 2 commits into from
Jul 25, 2022

Conversation

mxschmitt
Copy link
Member

Fixes #15898

@mxschmitt mxschmitt requested a review from rwoll July 24, 2022 11:24
dgozman
dgozman approved these changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a TSC test for playwright.config.ts that would cover some of the more interesting options we have?

@mxschmitt mxschmitt merged commit 004cd92 into microsoft:main Jul 25, 2022
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Jul 25, 2022
@mxschmitt
cherry-pick(microsoft#15901): fix(test-runner): multiple webServer types
dbf6579 
SHA: 004cd92
mxschmitt added a commit that referenced this pull request Jul 25, 2022
@mxschmitt
cherry-pick(#15901): fix(test-runner): multiple webServer types (#15916)
1b2cb1c 
SHA: 004cd92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@rwoll rwoll Awaiting requested review from rwoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Typescript error: The type for webServer config property (TestConfigWebServer) is not typed correctly
2 participants
@mxschmitt @dgozman