Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct): pass local config to preview #16481

Merged
merged 1 commit into from Aug 12, 2022

Conversation

pavelfeldman
Copy link
Member

Fixes #16460

Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump your

const VERSION = 6;

to 7 for good measure?

@rwoll
Copy link
Member

rwoll commented Aug 11, 2022

Shall we also add a test?

@pavelfeldman pavelfeldman force-pushed the preview_config branch 3 times, most recently from e2827d6 to 60712e8 Compare August 11, 2022 23:49
@rwoll rwoll self-requested a review August 12, 2022 00:27
Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the test!

@pavelfeldman pavelfeldman merged commit e1d3246 into microsoft:main Aug 12, 2022
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Component test fails on 2nd run when SSL is used
3 participants