Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow sibling describes with the same name #21967

Merged
merged 1 commit into from
Mar 25, 2023
Merged

chore: allow sibling describes with the same name #21967

merged 1 commit into from
Mar 25, 2023

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Mar 24, 2023 •
edited

Fixes #21953

dgozman
dgozman approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to rename this PR to "allow sibling describes with the same name", because it is about suites and not tests.

@pavelfeldman pavelfeldman changed the title chore: disambiguate parameterized tests chore: allow sibling describes with the same name Mar 24, 2023
@aslushnikov aslushnikov merged commit add948c into microsoft:main Mar 25, 2023
aslushnikov added a commit that referenced this pull request Mar 25, 2023
@aslushnikov
cherry-pick(#21967): chore: allow sibling describes with the same name
1869bd2 
Fixes #21953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Parameterized tests are not displayed in the UI mode
3 participants
@pavelfeldman @dgozman @aslushnikov