devops: do not use NPX during docker container build #23213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The postmortem of the broken docker image: - We use `playwright-core` package when bootstrapping our docker container. - Due to accidental removal of `bin` entry in the `playwright-core` (see microsoft#23206), the `npx playwright install --with-deps` was using the last published Playwright version instead of a locally-built playwright binary This patch starts using `npx exec --no` to make sure that we never call remote commands during docker image build.
dgozman
approved these changes
May 22, 2023
mxschmitt
approved these changes
May 23, 2023
aslushnikov
added a commit
that referenced
this pull request
May 24, 2023
…uild The postmortem of the broken docker image: - We use `playwright-core` package when bootstrapping our docker container. - Due to accidental removal of `bin` entry in the `playwright-core` (see #23206), the `npx playwright install --with-deps` was using the last published Playwright version instead of a locally-built playwright binary This patch starts using `npx exec --no` to make sure that we never call remote commands during docker image build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The postmortem of the broken docker image:
playwright-corepackage when bootstrapping our dockercontainer.
binentry in theplaywright-core(see[BUG] Unable to install supported browsers for v1.34.0 from playwright-core #23206), the
npx playwright install --with-depswas using the last publishedPlaywright version instead of a locally-built playwright binary
This patch starts using
npx exec --noto make sure that we never callremote commands during docker image build.