Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow calling spawnSync on Node.js file inside test #26429

Merged
merged 1 commit into from Aug 11, 2023

Conversation

mxschmitt
Copy link
Member

Fixes #24516

Relates #16733

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › expect-to-pass.spec.ts:208:5 › should show intermediate result for toPass that spills over test time

13 flaky
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events
⚠️ [playwright-test] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:218:5 › should show trace w/ multiple contexts
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events
⚠️ [playwright-test] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions

25025 passed, 583 skipped
✔️✔️✔️

[playwright-test] › expect-to-pass.spec.ts:208:5 › should show intermediate result for toPass that spills over test time

Error: expect(received).toContain(expected) // indexOf

Expected substring: "Expected: 2"
Received string:    "
Running 1 test using 1 worker·
  ✘  1 a.spec.ts:3:11 › should fail (1.0s)··
  1) a.spec.ts:3:11 › should fail ──────────────────────────────────────────────────────────────────·
    Test timeout of 1000ms exceeded.·
  1 failed
    a.spec.ts:3:11 › should fail ───────────────────────────────────────────────────────────────────
"

  218 |   }, { timeout: 1000 });
  219 |   expect(result.exitCode).toBe(1);
> 220 |   expect(result.output).toContain('Expected: 2');
      |                         ^
  221 |   expect(result.output).toContain('Received: 3');
  222 | });
  223 |

    at /Users/runner/work/playwright/playwright/tests/playwright-test/expect-to-pass.spec.ts:220:25

Merge workflow run.

@mxschmitt mxschmitt merged commit bd988b3 into microsoft:main Aug 11, 2023
26 of 28 checks passed
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running node execSync not working in Playwright
2 participants