Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list tests only once #27103

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: list tests only once #27103

merged 2 commits into from
Sep 15, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 15, 2023 •
edited by mxschmitt

Fixes #27087
Closes #27093

mxschmitt
mxschmitt approved these changes Sep 15, 2023
View reviewed changes
tests/playwright-test/reporter.spec.ts Outdated Show resolved Hide resolved
tests/playwright-test/reporter.spec.ts Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:395:14 › should produce screencast frames fit
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25615 passed, 605 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit ebf6a08 into microsoft:main Sep 15, 2023
27 of 28 checks passed
@yury-s yury-s deleted the list-twice branch September 15, 2023 03:00
yury-s added a commit to yury-s/playwright that referenced this pull request Sep 15, 2023
@yury-s
cherry-pick(microsoft#27103): fix: list tests only once
c53138c 
Fixes microsoft#27087
yury-s added a commit that referenced this pull request Sep 15, 2023
@yury-s
cherry-pick(#27103): fix: list tests only once (#27107)
476b74f 
Fixes #27087
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@yury-s @Germandrummer92
fix: list tests only once (microsoft#27103)
ef0eed7 
Fixes microsoft#27087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: npx playwright test --list prints all tests twice
2 participants
@yury-s @mxschmitt