Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(trace): allow Trace Viewer to include credentials when fetching traces cross-origin (#28502)" #29024

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 17, 2024

This reverts commit 3f3f332.

References #29019.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page

4 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21297 passed, 579 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 300a012 into microsoft:main Jan 17, 2024
29 of 30 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants